Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converter outputs invalid JSON #182

Closed
pjcozzi opened this issue Nov 12, 2013 · 6 comments
Closed

Converter outputs invalid JSON #182

pjcozzi opened this issue Nov 12, 2013 · 6 comments

Comments

@pjcozzi
Copy link
Member

pjcozzi commented Nov 12, 2013

A COLLADA file with the following node generates invalid glTF JSON:

<node id="Light-sunLight011Node" name="Directional_Light" type="NODE">
  <translate sid="translation012">-2 2 2</translate>
  <rotate sid="rotation013Y">0 1 0 -45</rotate>
  <rotate sid="rotation013X">1 0 0 -30</rotate>
  <rotate sid="rotation013Z">0 0 1 0</rotate>
  <instance_light url="#Light-sunLight011" />
</node>

In particular, it creates:

    "lights": {
        ""
    },

The COLLADA model was created and exported with LightWave.

@fabrobinet will send you the model.

@fabrobinet
Copy link
Contributor

Thanks @pjcozzi I'll have a look

@pjcozzi
Copy link
Member Author

pjcozzi commented Dec 9, 2013

Can we address this for dev-4? I have another model with the same issue - perhaps the exporter's issue.

@fabrobinet
Copy link
Contributor

yes, for dev-4. Due to an input issue from the COLLADA file but converter should be more robust.

@pjcozzi
Copy link
Member Author

pjcozzi commented Jan 31, 2014

Added coming-next label since this is for dev-4

@fabrobinet
Copy link
Contributor

@pjcozzi Actually when I fix a bug, to be able to sort things out, I remove coming-next and I replace by branch if there is no more work to do. If there is partial work done, I just add branch label. So for this one, not having coming-next is good. To see everything, coming and already fixed, just filter with both branch and coming-next.

@pjcozzi
Copy link
Member Author

pjcozzi commented Jan 31, 2014

OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants