Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename primitive in mesh/primitive to mode #341

Closed
glome83 opened this issue Dec 16, 2014 · 6 comments
Closed

Rename primitive in mesh/primitive to mode #341

glome83 opened this issue Dec 16, 2014 · 6 comments

Comments

@glome83
Copy link

glome83 commented Dec 16, 2014

There's a property named "primitive" in "mesh/primitive". This can lead to confusion. Rename it to "mode" as it is called in glDrawArrays etc.

@fabrobinet
Copy link
Contributor

@glome83 Thanks for bringing this to our attention, so as here:

      "primitives": [
                {
                    "attributes": {
                        "NORMAL": "accessor_25",
                        "POSITION": "accessor_23",
                        "TEXCOORD_0": "accessor_27"
                    },
                    "indices": "accessor_21",
                    "material": "blinn3-fx",
                    "primitive": 4
                }
            ]

you suggest instead:

      "primitives": [
                {
                    "attributes": {
                        "NORMAL": "accessor_25",
                        "POSITION": "accessor_23",
                        "TEXCOORD_0": "accessor_27"
                    },
                    "indices": "accessor_21",
                    "material": "blinn3-fx",
                    "mode": 4
                }
            ]

Which I don't have a strong opinion about this but I undertand that it could be less confusing - only concern here is I don't find mode particularly explicit but it is true that is matches the GL naming of arguments and since the value is a glEnum it's fine...

@pjcozzi what do you think ?

@pjcozzi
Copy link
Member

pjcozzi commented Jan 2, 2015

This probably better since "primitives/primitive" isn't used in two different contexts. Should I update the spec?

@fabrobinet
Copy link
Contributor

@pjcozzi yeah, let's do it for 0.9

@fabrobinet fabrobinet self-assigned this Jan 2, 2015
@fabrobinet fabrobinet added this to the Spec 1.0 milestone Jan 2, 2015
@pjcozzi
Copy link
Member

pjcozzi commented Jan 5, 2015

Updated the spec in 5bcf79e in the spec-9 branch.

@pjcozzi
Copy link
Member

pjcozzi commented Aug 27, 2015

This can be closed when 1.0 is merged...or now.

@pjcozzi pjcozzi removed this from the Spec 1.0 milestone Aug 27, 2015
@pjcozzi
Copy link
Member

pjcozzi commented Sep 16, 2015

This is done in the spec-1.0 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants