Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot use on Huawei without Google #16

Open
ghost opened this issue Mar 25, 2022 · 14 comments
Open

Cannot use on Huawei without Google #16

ghost opened this issue Mar 25, 2022 · 14 comments
Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested

Comments

@ghost
Copy link

ghost commented Mar 25, 2022

Unfortunately, the App from F-Droid is not compatible with a Huawei P40 Lite E (cannot install).

Does it requires Google Services ? Is there any way to use it without Google services ?

Thanks for your great project and for using a GPLv3 License ! :)

@KiARC
Copy link
Owner

KiARC commented Mar 25, 2022

There's probably a Google library somewhere, I'll see if I can remove it.

@KiARC
Copy link
Owner

KiARC commented Mar 25, 2022

Looks like FloatingActionButtons are from a Google library... Still looking though.

@KiARC KiARC added the enhancement New feature or request label Mar 25, 2022
@KiARC
Copy link
Owner

KiARC commented Mar 25, 2022

I've made a branch for this but I think this will end up being a long term goal

@ghost
Copy link
Author

ghost commented Mar 25, 2022

Thanks for your hard work ! I would like to try your "Sobriety" someday. :D

@KiARC
Copy link
Owner

KiARC commented May 5, 2022

Yeah the issue is the use of components from com.google.android.material which isn't available on Huawei devices. It could be removed but it would present some design challenges. I'm curious as to whether ShadowJar could help here, it's possible that packing that library into the app (or at least the portions the app uses) could solve it, but I would need to look into the license on the library as well.

@KiARC
Copy link
Owner

KiARC commented May 5, 2022

For now HarmonyOS (a modified version of Android which Huawei devices run) should be considered unsupported, but I'm working on it.

@KiARC
Copy link
Owner

KiARC commented May 5, 2022

Looks like the licensing on com.google.android.material is Apache v2 so there's no legal issues. Shadowing might fix this which would be great.

@KiARC
Copy link
Owner

KiARC commented May 5, 2022

The one issue is I can't figure out how to properly shadow classes/packages in an APK.

@KiARC KiARC added the help wanted Extra attention is needed label May 5, 2022
@KiARC
Copy link
Owner

KiARC commented Sep 14, 2022

Unfortunately this is somewhat difficult and might not happen :/

@unbiaseduser
Copy link
Contributor

I would like to chime in a bit.
So, I researched the phone Huawei P40 Lite E and I can see that it launched with Android 9 (and maybe has been updated to Android 10).
Looking at the app's commit history, I came across a commit on Sep 14 that decreases the minimum Android version from Android 11 to Android 8.
So, I came to the conclusion that when the issue was created (March 26), the app required Android 11 or later to run. That's why the author could not install the app.

@KiARC
Copy link
Owner

KiARC commented Oct 17, 2022 via email

@unbiaseduser
Copy link
Contributor

I'm 100% percent sure that Google material library, or any library not depending on Google services, will run on any Android variant. If you don't believe me then at least hear this out: I've been a dev for some 6 months or so, common sense tells me that the thing you're suspecting is not true. Android is Android, Google-less or not.
Furthermore, if the system does not support some runtime dependencies, the app will crash at runtime, not throw a 'incompatible' error when installing.

@KiARC
Copy link
Owner

KiARC commented Oct 17, 2022 via email

@KiARC KiARC added the question Further information is requested label Nov 11, 2022
@KiARC
Copy link
Owner

KiARC commented Nov 11, 2022

Could anyone with a Huawei device test Sobriety and lmk if it works? The Java version was bumped down a lot since this was opened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants