Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Holes wrong in OMRON relays #1589

Closed
hildogjr opened this issue May 9, 2019 · 3 comments
Closed

Holes wrong in OMRON relays #1589

hildogjr opened this issue May 9, 2019 · 3 comments
Labels
Bug Fix footprint existing in the library

Comments

@hildogjr
Copy link
Contributor

hildogjr commented May 9, 2019

I did the pull requests #1587 and #1588 for fix the hole error in the OMROS relays, see datasheet https://omronfs.omron.com/en_US/ecb/products/pdf/en-g5q.pdf

But I am getting a CI error of layer overlap that I don't understand.

@hildogjr hildogjr changed the title Holes wrong in OSROM relays Holes wrong in OMRON relays May 9, 2019
@evanshultz
Copy link
Collaborator

Well, you need to look at the footprint:
image

Here is the exact error message:

Violating F5.4
    Elements on the graphic layer should not overlap
    F.SilkS graphic elements should not overlap.
     - The following elements do overlap at least one other graphic element on the same layer
     - Line (2.03,-4.83) -> (2.54,-4.83) on layer 'F.SilkS'
     - Line (3.05,-2.29) -> (2.54,-2.29) on layer 'F.SilkS'

So a silk line is overlapping something on the same layer. (I'm not familiar with this exact part of the check script but it seems clear so I continued on.)

Looking at the above and checking the given locations, it appears the error is because the top and bottom of the coil are composed of two horizontal lines. Delete one and extend the other so the rectangle indicating the coil just uses four line and all will probably be well.

(Since only the endpoints are in common this error might be a bit aggressive, but if it's only checking for lines in the same orientation where they can be a single line it's relatively valid.)

IMO it's not required to make other updates when correcting a true issue, so I will merge without improving the silk lines. But if you want to tackle that fix I'm happy to merge those improvements too.

The silk outline is offset quite far from the fab outline. You could shrink the offset to 0.11-0.2mm if you like while you're at it. But again, this is not required.

@hildogjr
Copy link
Contributor Author

hildogjr commented May 9, 2019

Thanks. Maybe I will deal with other time, because appear that the checking is complain of overlap because the beginning-end of different line at same coordinates.

@evanshultz
Copy link
Collaborator

That's fine. I merged both of the PRs you submitted to fix the hole size issue. Thanks again!

@herostrat herostrat added the Bug Fix footprint existing in the library label Jun 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Fix footprint existing in the library
Projects
None yet
Development

No branches or pull requests

3 participants