Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Temperature_Sensors -> MCP9804_DFN has wrong package #2732

Closed
svollenweider opened this issue May 15, 2020 · 6 comments · Fixed by #3089
Closed

Temperature_Sensors -> MCP9804_DFN has wrong package #2732

svollenweider opened this issue May 15, 2020 · 6 comments · Fixed by #3089
Assignees
Labels
Bug Fix symbol existing in the library

Comments

@svollenweider
Copy link

The MCP9804_DFN has the wrong package (3x3 DFN). The correct package would be

Package_DFN_QFN:DFN-8-1EP_3x2mm_P0.5mm_EP1.3x1.5mm

@chschlue chschlue added the Bug Fix symbol existing in the library label May 15, 2020
@chschlue chschlue self-assigned this May 15, 2020
@chschlue
Copy link
Contributor

Confirmed.

The current package is completely wrong. However, neither your suggestion nor DFN-8-1EP_3x2mm_P0.5mm_EP1.75x1.45mm which we have for Microchip's MC package is completely correct.
Both are within the EP tolerance and so are both acceptable, but the best solution would be to generate a new footprint using the generator at https://github.com/pointhi/kicad-footprint-generator/tree/master/scripts/Packages/Package_NoLead__DFN_QFN_LGA_SON. Would you be willing to do that?

@svollenweider
Copy link
Author

svollenweider commented May 15, 2020

Hey
I added a package with a 1.4mm x 1.7mm base under this pull request

KiCad/kicad-footprints#2284

I will also create a pull request for the generator, if desired

@chschlue
Copy link
Contributor

Yes, absolutely.
In fact, we generally trust the generator's correctness and actually check its input instead of its output to review scripted FP additions.

@svollenweider
Copy link
Author

Here you go

@chschlue
Copy link
Contributor

Thanks.

@chschlue
Copy link
Contributor

chschlue commented Aug 4, 2020

FP merged. Are you going to update the symbol, too?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Fix symbol existing in the library
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants