Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

The 5.0.1 release is planned for end of septemper. Anything we want to have included in it? #856

Closed
poeschlr opened this issue Aug 28, 2018 · 13 comments
Closed

The 5.0.1 release is planned for end of septemper. Anything we want to have included in it? #856

poeschlr opened this issue Aug 28, 2018 · 13 comments
Milestone
5.0.1

Comments

@poeschlr
Copy link
Collaborator

https://lists.launchpad.net/kicad-developers/msg37283.html
@poeschlr
Copy link
Collaborator Author

@evanshultz, @Ratfink, @jkriege2, @Shackmeister
How strict have you guys been with avoiding merging stuff that would break existing projects? If we have been strict enough then we can include an updated library into the next bugfix release. Otherwise that release will continue using the original version 5 release (Meaning no bugfixes and no new additions will make it into kicad until version 6 is released.)

My intent was to be as strict as described in this mailing list message. Could you read it and tell me if we to the best of our knowledge fulfill the promises given in it?
https://lists.launchpad.net/kicad-developers/msg37312.html

@evanshultz
Copy link
Collaborator

While I haven't checked anything, I don't recall any major changes off the top of my head. There has been a lot added and fixed, but it's all incremental in my recollection. I believe any breaking changes should be minor.

@poeschlr
Copy link
Collaborator Author

I plan on writting a script that will give us a list of symbols that have design breaking changes. This list should allow us to make an informed decision.

@poeschlr
Copy link
Collaborator Author

poeschlr commented Aug 31, 2018 •
edited
Loading

I found we have the following design breaking changes made in the symbol lib since the 5.0.0 tag

Deleted or renamed symbols:

  • 'Driver_FET.lib:IR2106'
  • 'Regulator_Linear.lib:MIC5205-ADJ'

Symbols with moved, renumbered or removed pins:

  • 'Driver_FET.lib:FAN7371'
  • 'Driver_FET.lib:FAN7842'
  • 'Driver_FET.lib:IRS2186'
  • 'Driver_FET.lib:LM5109ASD'
  • 'Driver_FET.lib:LM5109MA'
  • 'MCU_Microchip_ATmega.lib:ATmega8L-8AU'
  • 'MCU_Microchip_ATmega.lib:ATmega8L-8MU'
  • 'MCU_Microchip_ATmega.lib:ATmega8L-8PU'
  • 'MCU_Microchip_ATmega.lib:ATxmega256A3B-MH'
  • 'MCU_Microchip_ATmega.lib:ATxmega256A3BU-AU'
  • 'MCU_Microchip_ATmega.lib:ATxmega256A3BU-MH'
  • 'MCU_Microchip_ATmega.lib:ATxmega64B1-AU'
  • 'MCU_Microchip_ATmega.lib:ATxmega64B1-CU'
  • 'MCU_Microchip_ATmega.lib:ATxmega64B3-AU'
  • 'MCU_Microchip_ATmega.lib:ATxmega64B3-MH'
  • 'Memory_Flash.lib:M29W004'
  • 'Reference_Voltage.lib:TLE2426xLP'
  • 'Sensor_Magnetic.lib:AS5045B'
  • 'Sensor_Magnetic.lib:AS5048A'
  • 'Sensor_Magnetic.lib:AS5048B'
  • 'Sensor_Magnetic.lib:AS5055A'

Symbols where only NC pins have been touched (most likely moved onto the part outline. These changes should definetely be ok):

  • 'Driver_FET.lib:EL7202CN'
  • 'Driver_FET.lib:EL7212CN'
  • 'Driver_FET.lib:EL7222CN'
  • 'Driver_FET.lib:HIP2100_DFN'
  • 'Driver_FET.lib:HIP2100_QFN'
  • 'Driver_FET.lib:ICL7667'
  • 'Driver_FET.lib:IR2110'
  • 'Driver_FET.lib:LTC4440EMS8'
  • 'Driver_FET.lib:MCP1415'
  • 'Driver_FET.lib:MCP1415R'
  • 'Driver_FET.lib:MCP1416'
  • 'Driver_FET.lib:MCP1416R'
  • 'Driver_FET.lib:MIC4426'
  • 'Driver_FET.lib:MIC4427'
  • 'Driver_FET.lib:MIC4428'

@Ratfink
Copy link
Collaborator

Ratfink commented Aug 31, 2018

Driver_FET.lib:IR2106 wasn't actually deleted, it was turned into an alias of Driver_FET.lib:IR2101 in d54589d.

@poeschlr
Copy link
Collaborator Author

Oh. Hm that means my script needs a bit more power.
(Might also need to check for aliases that are no longer aliases.)

@antoniovazquezblanco antoniovazquezblanco modified the milestones: 5.1.0, 5.0.1 Oct 4, 2018
@antoniovazquezblanco
Copy link
Collaborator

Release is comming. How are we doing with this? What needs to be done?

@poeschlr
Copy link
Collaborator Author

poeschlr commented Oct 4, 2018 •
edited
Loading

Run the testscript i wrote, ask over at the mailing list if the changes are within acceptable limits. If yes tag the current master with 5.0.1. If not no new tag should be made in my opineon. But the packagers might not like it that way as they would need to change their scripts to still get the tag for 5.0.0 for the libraries.

Edit: My testscript requires you to have two copies of the lib. One that is on 5.0.0 and one that is on current master. It reports changed pin positions and also deleted (or renamed) symbols.

@antoniovazquezblanco
Copy link
Collaborator

Worst case scenario the tag for 5.0.1 can be set to point to the 5.0.0 commit in order to avoid changes for packagers. Little bit better scenario we can point to the previous commit that first breaks compatibility.

@evanshultz
Copy link
Collaborator

So what is going to the included with 5.0.1? It's supposed to be tagged in a matter of hours (https://lists.launchpad.net/kicad-developers/msg37819.html).

I know you're going to check out the delta changes, Rene.

The only outstanding PR I see as important to merge is #1044 since a user reported an error in the library and destroyed a part due to it. Otherwise, and since that one isn't critical, merging it and tagging 5.0.1 or leaving 5.0.0 is OK with me.

@poeschlr
Copy link
Collaborator Author

poeschlr commented Oct 8, 2018 •
edited
Loading

Fix merged Edit: Wrong issue

@poeschlr poeschlr closed this as completed Oct 8, 2018
@poeschlr poeschlr reopened this Oct 8, 2018
@poeschlr
Copy link
Collaborator Author

poeschlr commented Oct 8, 2018 •
edited
Loading

I ran my test script again. A few more symbols now have incompatible changes. (Edit: a bit inflated as i now also included aliases in the list.)

Full report file: report.txt
There are 1183 changed symbols that are still compatible with earlier releases
There are 355 new symbols

Now a list of the incompatible changes:

Pins have been moved, renumbered or removed in the following symbols:

Normal pins ok but NC pins have been moved, renumbered or removed in the following symbol:

  • 'Driver_FET.lib:HIP2100_DFN'
  • 'Driver_FET.lib:HIP2101_DFN' alias of HIP2100_DFN
  • 'Driver_FET.lib:HIP2100_QFN'
  • 'Driver_FET.lib:HIP2101_QFN' alias of HIP2100_QFN
  • 'Driver_FET.lib:IR2110'
  • 'Driver_FET.lib:IR2113' alias of IR2110
  • 'Driver_FET.lib:LTC4440EMS8'
  • 'Driver_FET.lib:LTC4440IMS8' alias of LTC4440EMS8
  • 'Driver_FET.lib:MCP1415'
  • 'Driver_FET.lib:MCP1415R'
  • 'Driver_FET.lib:MCP1416'
  • 'Driver_FET.lib:MCP1416R'
  • 'Power_Protection.lib:NUP2202'
  • 'Power_Protection.lib:SN65220'

Removed or renamed have been the following symbols:

  • 'MCU_Microchip_ATtiny.lib:ATtiny48-MMH'
  • 'MCU_Microchip_ATtiny.lib:ATtiny88-MMH' was an alias of ATtiny48-MMH
  • 'MCU_Microchip_PIC16.lib:PIC16F18346-SS'

Renamed (bugfix, added correct suffix to indicate which package the symbol uses. PR: #826):

  • 'Regulator_Linear.lib:MIC5219-3.3' was an alias of AP131-15
  • 'Regulator_Linear.lib:MIC5219-2.5' was an alias of AP131-15
  • 'Regulator_Linear.lib:MIC5219-2.6' was an alias of AP131-15
  • 'Regulator_Linear.lib:MIC5219-2.7' was an alias of AP131-15
  • 'Regulator_Linear.lib:MIC5219-2.8' was an alias of AP131-15
  • 'Regulator_Linear.lib:MIC5219-2.9' was an alias of AP131-15
  • 'Regulator_Linear.lib:MIC5219-3.1' was an alias of AP131-15
  • 'Regulator_Linear.lib:MIC5219-3.0' was an alias of AP131-15
  • 'Regulator_Linear.lib:MIC5219-3.6' was an alias of AP131-15
  • 'Regulator_Linear.lib:MIC5219-5.0' was an alias of AP131-15
  • 'Regulator_Linear.lib:MIC5205-2.5' was an alias of AP131-15
  • 'Regulator_Linear.lib:MIC5205-2.7' was an alias of AP131-15
  • 'Regulator_Linear.lib:MIC5205-2.8' was an alias of AP131-15
  • 'Regulator_Linear.lib:MIC5205-2.85' was an alias of AP131-15
  • 'Regulator_Linear.lib:MIC5205-2.9' was an alias of AP131-15
  • 'Regulator_Linear.lib:MIC5205-3.0' was an alias of AP131-15
  • 'Regulator_Linear.lib:MIC5205-3.1' was an alias of AP131-15
  • 'Regulator_Linear.lib:MIC5205-3.2' was an alias of AP131-15
  • 'Regulator_Linear.lib:MIC5205-3.3' was an alias of AP131-15
  • 'Regulator_Linear.lib:MIC5205-3.6' was an alias of AP131-15
  • 'Regulator_Linear.lib:MIC5205-3.8' was an alias of AP131-15
  • 'Regulator_Linear.lib:MIC5205-4.0' was an alias of AP131-15
  • 'Regulator_Linear.lib:MIC5205-5.0' was an alias of AP131-15
  • 'Regulator_Linear.lib:MIC5205-ADJ'

@poeschlr
Copy link
Collaborator Author

poeschlr commented Oct 8, 2018

Wayne gave the ok so i will tag the current state of the lib as 5.0.1.
See: https://lists.launchpad.net/kicad-developers/msg37835.html

@poeschlr poeschlr closed this as completed Oct 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0.1
Development

No branches or pull requests
4 participants
@antoniovazquezblanco @Ratfink @evanshultz @poeschlr