Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Grammarly Breaks Quill #40

Closed
blundercode opened this issue May 9, 2017 · 5 comments
Closed

Using Grammarly Breaks Quill #40

blundercode opened this issue May 9, 2017 · 5 comments

Comments

@blundercode
Copy link

blundercode commented May 9, 2017

  1. What is Grammarly
  2. Download Chrome Extension
  3. Visit Demo Page
  4. Attempt to use Quill while Grammarly is enabled.

When Grammarly is enabled on a page that uses the ngx-quill Editor the editor is rendered basically useless, making selecting text impossible and inserting text into the middle of a sentence impossible. The editor I'm using to write this isn't having problems so I know it's possible to correct this issue.

Grammarly is used by a huge amount of people just wanted to let you know about this. So more devs can adopt Quill without worry of users not being able to use the editor.

@KillerCodeMonkey
Copy link
Owner

Did you checked if this works with pure QuillJS. Or do you have any idea how to disable grammarly or such plugins in general for Quill?

@KillerCodeMonkey
Copy link
Owner

@blundercode i checked it out --> this issues has something to do with latest quill versions I think. When I try it with QuillJS 1.0.0-beta.3 or some other beta version it seems some how to work with Grammarly.

Since the RC releases, it does not work anymore.

This occurs also in the ng-quill repo. There you can easily play around with the quill versions in the demo.html.

@blundercode
Copy link
Author

So we just have to wait to wait till its fixed in Quill-Js? I can look into a fix and create a PR for it when I get a moment if you think it's worth fixing now?

@KillerCodeMonkey
Copy link
Owner

feel free 👍

@KillerCodeMonkey
Copy link
Owner

Check out Jason Chen's answer to this topic:
slab/quill#574

So, i think i can close this here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants