Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update angular dependency #210

Closed
jecraig opened this issue Apr 27, 2020 · 7 comments
Closed

Update angular dependency #210

jecraig opened this issue Apr 27, 2020 · 7 comments
Labels
angular Issue has a connection to the Angular framework. 🍐 improvement

Comments

@jecraig
Copy link

jecraig commented Apr 27, 2020

Cannot use the Angular cli update command to update to Angular 9 without --force because the packages.json marks 7 as the latest supported version.

C:\Code\d8\web\aeclient>ng update @angular/core
Using package manager: 'npm'
Collecting installed dependencies...
Found 76 dependencies.
Fetching dependency metadata from registry...
                  Package "overlayscrollbars-ngx" has an incompatible peer dependency to "@angular/core" (requires "^7.0.0" (extended), would install "9.1.3").
× Migration failed: Incompatible peer dependencies found.
Peer dependency warnings when installing dependencies means that those dependencies might not work correctly together.
You can use the '--force' option to ignore incompatible peer dependencies and instead address these warnings later.
@KingSora
Copy link
Owner

Good day!

Thanks, I'll fix this as soon as possible.

@KingSora KingSora added 🍐 improvement angular Issue has a connection to the Angular framework. labels Apr 27, 2020
@TokkeDev
Copy link

What's the status on this? 😊

@KingSora
Copy link
Owner

@TokkeDev I'm sorry I lost the sight of this issue because I focused so hard on v2.0.0. I'll do my best to solve this in the next release.

@TokkeDev
Copy link

No worries 😊 That sounds good 👌

@lovelyc4t
Copy link

Hi @KingSora first of all, really love the plugin, kudos! ❤️ Is there any chance of bumping angular dependencies soon? Best love!

@TokkeDev
Copy link

TokkeDev commented Dec 4, 2020

@KingSora, everything seems to be working just fine with both Angular 9, Angular 10 and Angular 11, so shouldn't we just bump the peer dep version af Angular to accept 11? 😊

@KingSora
Copy link
Owner

@TokkeDev @lovelyc4t @jecraig
Fixed with version 1.13.1 / "overlayscrollbars-ngx": "0.2.3"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
angular Issue has a connection to the Angular framework. 🍐 improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants