We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We noticed an issue when the vertical overflow calculation impacting horizontal overflow.
The issue is narrowed down to force rounding code below, where in overflowAmount.x check makes overflowAmount.y as zero even in valid cases
var hideOverflowForceRounding = (_viewportElement[0].scrollLeftMax === 0 && overflowAmount.x > 0 && overflowAmount.x < 1) || (_viewportElement[0].scrollTopMax === 0 && overflowAmount.y > 0 && overflowAmount.y < 1); if (hideOverflowForceTextarea || hideOverflowForceRounding) overflowAmount.x = overflowAmount.y = 0;
We have fixed by making 2 different variables each for x and y calculations like below
var hideOverflowForceRoundingX = (_viewportElement[0].scrollLeftMax === 0 && overflowAmount.x > 0 && overflowAmount.x < 1); var hideOverflowForceRoundingY = (_viewportElement[0].scrollTopMax === 0 && overflowAmount.y > 0 && overflowAmount.y < 1); if (hideOverflowForceTextarea || hideOverflowForceRoundingX) overflowAmount.x = 0; if (hideOverflowForceTextarea || hideOverflowForceRoundingY) overflowAmount.y = 0;
The text was updated successfully, but these errors were encountered:
Good day!
Thanks for your contribution! I'll implement it as soon as I've time, but at the earliest in 2 weeks, because I'm on vacation right now.
Sorry, something went wrong.
Small update here, because its been a while. I've fixed this issue and it will definitely be included in the next version!
Version 1.7.0 is now out!
No branches or pull requests
We noticed an issue when the vertical overflow calculation impacting horizontal overflow.
The issue is narrowed down to force rounding code below, where in overflowAmount.x check makes overflowAmount.y as zero even in valid cases
We have fixed by making 2 different variables each for x and y calculations like below
The text was updated successfully, but these errors were encountered: