Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧Replace moq with nsubstitute #132

Open
4 of 11 tasks
CalvinWilkinson opened this issue Oct 2, 2023 · 0 comments
Open
4 of 11 tasks

🚧Replace moq with nsubstitute #132

CalvinWilkinson opened this issue Oct 2, 2023 · 0 comments
Labels
🍺hacktoberfest-medium Medium issue for mid-level developers for hacktoberfest!! Hack away!! medium-priority Medium Priority tech-debt Code refactoring or cleanup / tech debt reduction

Comments

@CalvinWilkinson
Copy link
Member

CalvinWilkinson commented Oct 2, 2023

Complete The Item Below

  • I have updated the title without removing the 🚧 emoji.

Description

Replace all Moq code with NSubstitute code.

The files below are the only files that have Moq code setup:

  1. GitHubActionTests.cs
  2. MoqExtensions.cs
  3. ActionOutputServiceTests.cs

Install the following NuGet packages in the PackageMonsterTests project

  1. NSubstitute version v5.1.0
  2. NSubstitute.Analyzers.CSharp version v1.0.16

Remove the following NuGet packages from the PackageMonsterTests project

  1. Moq

Note
💡TIP💡
Remove the Moq package last AFTER all of the Moq code has been replaced. This way the IDE/tooling can help you in regards to what the Moq code does when it comes to API docs and usage which will help guide you into the NSubstitute equivalent.

Acceptance Criteria

  • NSubstitute packages installed
  • Moq package removed
  • Moq code replaced with NSubstitute code
    • Code replaced in the GitHubActionTests.cs file
    • Code replaced in the MoqExtensions.cs file
    • Code replaced in the ActionOutputServiceTests.cs file

ToDo Items

  • Change type labels added to this issue. Refer to the Change Type Labels section below.
  • Priority label added to this issue. Refer to the Priority Type Labels section below.
  • Issue linked to the correct milestone (if applicable).

Issue Dependencies

No response

Related Work

No response

Additional Information:

Change Type Labels

Change Type Label
Bug Fixes 🐛bug
Breaking Changes 🧨breaking changes
New Feature ✨new feature
CICD Changes ♻️cicd
Config Changes ⚙️config
Performance Improvements 🏎️performance
Code Doc Changes 🗒️documentation/code
Product Doc Changes 📝documentation/product

Priority Type Labels

Priority Type Label
Low Priority low priority
Medium Priority medium priority
High Priority high priority

Code of Conduct

  • I agree to follow this project's Code of Conduct.
@CalvinWilkinson CalvinWilkinson added medium-priority Medium Priority tech-debt Code refactoring or cleanup / tech debt reduction 🍺hacktoberfest-medium Medium issue for mid-level developers for hacktoberfest!! Hack away!! labels Oct 2, 2023
@github-project-automation github-project-automation bot moved this to ⚪Not Set in KD-Team Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍺hacktoberfest-medium Medium issue for mid-level developers for hacktoberfest!! Hack away!! medium-priority Medium Priority tech-debt Code refactoring or cleanup / tech debt reduction
Projects
Status: ⚪Not Set
Development

No branches or pull requests

1 participant