Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧Refactor unit test assertions #357

Closed
6 of 13 tasks
kselena opened this issue Sep 8, 2022 · 15 comments
Closed
6 of 13 tasks

🚧Refactor unit test assertions #357

kselena opened this issue Sep 8, 2022 · 15 comments
Assignees
Labels
good-first-issue Good for newcomers 🍺hacktoberfest-easy Easy issue for new developers for hacktoberfest!! Hack away!! medium-priority Medium Priority preview Done while in preview stale Signifies that an issue is stale tech-debt Code refactoring or cleanup / tech debt reduction

Comments

@kselena
Copy link
Member

kselena commented Sep 8, 2022

Complete The Item Below

  • I have updated the title without removing the 🚧 emoji.

Description

Refactor all of the unit test assertions to use the FluentAssertions library.
This will greatly cleanup the unit testing side of things and make the creation of unit tests easier.

Note

  1. We have been migrating all of our assertion code for the past 6 months from standard XUnit assertions API to FluentAssertions API API. Most of the code base has been converted and examples can be found all of the place. Please don't hesitate to ask questions and for help if needed.
  2. Please follow our Contribution Guide

Acceptance Criteria

  • Latest version of FluentAssertions Nuget package added to the project
  • Refactor the files below:
    • EnsureThatTests.cs - 55 lines
    • SystemDisplayTests.cs - 359 lines
    • InvalidInputExceptionTests.cs - 50 lines
    • NoKeyboardExceptionTests.cs - 50 lines
    • NoMouseExceptionTests.cs - 50 lines

ToDo Items

  • Change type labels added to this issue. Refer to the Change Type Labels section below.
  • Priority label added to this issue. Refer to the Priority Type Labels section below.
  • Issue linked to the correct project (if required).
  • Issue linked to the correct milestone (if required).

Issue Dependencies

No response

Related Work

No response

Additional Information:

Change Type Labels

Change Type Label
Bug Fixes 🐛bug
Breaking Changes 🧨breaking changes
New Feature ✨new feature
Workflow Changes workflow
Code Doc Changes 🗒️documentation/code
Product Doc Changes 📝documentation/product

Priority Type Labels

Priority Type Label
Low Priority low priority
Medium Priority medium priority
High Priority high priority

Code of Conduct

  • I agree to follow this project's Code of Conduct.
@kselena kselena added tech-debt Code refactoring or cleanup / tech debt reduction medium-priority Medium Priority labels Sep 8, 2022
@kselena kselena changed the title 🚧Refactor use test assertions 🚧Refactor unit test assertions Sep 8, 2022
@stale
Copy link

stale bot commented Nov 16, 2022

This issue has been automatically marked as stale due to the lack of activity for 60 days. The issue will be closed after 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Signifies that an issue is stale label Nov 16, 2022
@CalvinWilkinson CalvinWilkinson removed the stale Signifies that an issue is stale label Nov 16, 2022
@CalvinWilkinson CalvinWilkinson added the preview Done while in preview label Dec 21, 2022
@stale
Copy link

stale bot commented Feb 19, 2023

This issue has been automatically marked as stale due to the lack of activity for 60 days. The issue will be closed after 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Signifies that an issue is stale label Feb 19, 2023
@CalvinWilkinson CalvinWilkinson removed the stale Signifies that an issue is stale label Feb 21, 2023
@stale
Copy link

stale bot commented Apr 22, 2023

This issue has been automatically marked as stale due to the lack of activity for 60 days. The issue will be closed after 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Signifies that an issue is stale label Apr 22, 2023
@CalvinWilkinson CalvinWilkinson removed the stale Signifies that an issue is stale label Apr 24, 2023
@CalvinWilkinson CalvinWilkinson added the good-first-issue Good for newcomers label May 8, 2023
@CalvinWilkinson CalvinWilkinson removed their assignment May 8, 2023
@stale
Copy link

stale bot commented Jul 9, 2023

This issue has been automatically marked as stale due to the lack of activity for 60 days. The issue will be closed after 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Signifies that an issue is stale label Jul 9, 2023
@CalvinWilkinson CalvinWilkinson removed the stale Signifies that an issue is stale label Jul 9, 2023
@stale
Copy link

stale bot commented Sep 7, 2023

This issue has been automatically marked as stale due to the lack of activity for 60 days. The issue will be closed after 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Signifies that an issue is stale label Sep 7, 2023
@CalvinWilkinson CalvinWilkinson removed the stale Signifies that an issue is stale label Sep 9, 2023
@CalvinWilkinson CalvinWilkinson added the 🍺hacktoberfest-easy Easy issue for new developers for hacktoberfest!! Hack away!! label Oct 2, 2023
@ljdarj
Copy link
Contributor

ljdarj commented Oct 30, 2023

I wish to take up this issue if it's still current.

@CalvinWilkinson
Copy link
Member

Do not bother with refactoring the EnsureThatTests file. This file is being removed in another issue.

@CalvinWilkinson
Copy link
Member

Hello @ljdarj!!

I just wanted to touch base with you and see if you still plan on working with this issue. I noticed that no pull request has been created for this and it seems like there has not been any activity for about 3 weeks.

Thanks for any updates. 😀

@CalvinWilkinson
Copy link
Member

Just a quick side note @ljdarj.

If you do still plan on doing this, that is completely fine. I just needed to know which release to slot this in for. We can release it at a later time.

@ljdarj
Copy link
Contributor

ljdarj commented Dec 22, 2023

Sorry I wasn't here, life got in the way. I intend to do it by the first week of January at the latest.

@CalvinWilkinson
Copy link
Member

Sorry I wasn't here, life got in the way. I intend to do it by the first week of January at the latest.

Not a problem at all. 😀 I understand how life can get in the way. Especially as we approach the end of the year and the holidays.
I will just move the issue to another release.

Thanks for updating me!!

@CalvinWilkinson CalvinWilkinson removed this from the v1.0.0-preview.31 milestone Dec 24, 2023
@kselena
Copy link
Member Author

kselena commented Jan 22, 2024

@ljdarj Happy New Year!! I hope you're doing well. I am following up on this issue. If you're not able to work on it, that's completely understandable. Please let myself or @CalvinWilkinson know and we can take care of it. Thanks and have a great rest of your week!

Copy link

stale bot commented Mar 22, 2024

This issue has been automatically marked as stale due to the lack of activity for 60 days. The issue will be closed after 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Signifies that an issue is stale label Mar 22, 2024
@CalvinWilkinson CalvinWilkinson removed the stale Signifies that an issue is stale label Mar 23, 2024
Copy link

stale bot commented May 22, 2024

This issue has been automatically marked as stale due to the lack of activity for 60 days. The issue will be closed after 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Signifies that an issue is stale label May 22, 2024
Copy link

stale bot commented May 29, 2024

This stale issue has been closed due to a lack of activity.

@stale stale bot closed this as completed May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good-first-issue Good for newcomers 🍺hacktoberfest-easy Easy issue for new developers for hacktoberfest!! Hack away!! medium-priority Medium Priority preview Done while in preview stale Signifies that an issue is stale tech-debt Code refactoring or cleanup / tech debt reduction
Projects
Archived in project
Development

No branches or pull requests

3 participants