Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚧Refactor unit test assertions #359

Closed
13 tasks done
kselena opened this issue Sep 8, 2022 · 8 comments · Fixed by #763
Closed
13 tasks done

🚧Refactor unit test assertions #359

kselena opened this issue Sep 8, 2022 · 8 comments · Fixed by #763
Assignees
@thestbar
Labels
good-first-issue Good for newcomers 🍺hacktoberfest-easy Easy issue for new developers for hacktoberfest!! Hack away!! medium-priority Medium Priority preview Done while in preview tech-debt Code refactoring or cleanup / tech debt reduction
Milestone
v1.0.0-preview.29

Comments

@kselena
Copy link
Member

kselena commented Sep 8, 2022 •
edited by CalvinWilkinson
Loading

Complete The Item Below

  • I have updated the title without removing the 🚧 emoji.

Description

Refactor all of the unit test assertions to use the FluentAssertions library.
This will greatly cleanup the unit testing side of things and make the creation of unit tests easier.

Note

  1. We have been migrating all of our assertion code for the past 6 months from standard XUnit assertions API to FluentAssertions API API. Most of the code base has been converted and examples can be found all of the place. Please don't hesitate to ask questions and for help if needed.
  2. Please follow our Contribution Guide
  3. Join the KinsonDigital Community!!

Acceptance Criteria

  • Latest version of FluentAssertions Nuget package added to the project
  • Refactor the files below:
    • GLFWErrorEventArgsTests.cs - 37 lines
    • GLFWDisplayChangedEventArgsTests.cs - 22 lines
    • GLFWDisplayTests.cs - 211 lines
    • OpenGLServiceTests.cs - 439 lines
    • BufferManagerTests.cs - 158 lines

ToDo Items

  • Change type labels added to this issue. Refer to the Change Type Labels section below.
  • Priority label added to this issue. Refer to the Priority Type Labels section below.
  • Issue linked to the correct project (if required).
  • Issue linked to the correct milestone (if required).

Issue Dependencies

No response

Related Work

No response

Additional Information:

Change Type Labels

Change Type Label
Bug Fixes 🐛bug
Breaking Changes 🧨breaking changes
New Feature ✨new feature
Workflow Changes workflow
Code Doc Changes 🗒️documentation/code
Product Doc Changes 📝documentation/product

Priority Type Labels

Priority Type Label
Low Priority low priority
Medium Priority medium priority
High Priority high priority

Code of Conduct

  • I agree to follow this project's Code of Conduct.
@github-actions github-actions bot added the ⚕️NEEDS-TRIAGE Issue needs to be looked at and processed by a team member label Sep 8, 2022
@kselena kselena changed the title 🚧Refactor use test assertions 🚧Refactor unit test assertions Sep 8, 2022
@kselena kselena added tech-debt Code refactoring or cleanup / tech debt reduction medium-priority Medium Priority and removed ⚕️NEEDS-TRIAGE Issue needs to be looked at and processed by a team member labels Sep 8, 2022
@stale
Copy link

stale bot commented Nov 16, 2022

This issue has been automatically marked as stale due to the lack of activity for 60 days. The issue will be closed after 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Signifies that an issue is stale label Nov 16, 2022
@CalvinWilkinson CalvinWilkinson removed the stale Signifies that an issue is stale label Nov 16, 2022
@CalvinWilkinson CalvinWilkinson added the preview Done while in preview label Dec 21, 2022
@stale
Copy link

stale bot commented Feb 19, 2023

This issue has been automatically marked as stale due to the lack of activity for 60 days. The issue will be closed after 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Signifies that an issue is stale label Feb 19, 2023
@CalvinWilkinson CalvinWilkinson removed the stale Signifies that an issue is stale label Feb 21, 2023
@stale
Copy link

stale bot commented Apr 22, 2023

This issue has been automatically marked as stale due to the lack of activity for 60 days. The issue will be closed after 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Signifies that an issue is stale label Apr 22, 2023
@CalvinWilkinson CalvinWilkinson removed the stale Signifies that an issue is stale label Apr 24, 2023
@CalvinWilkinson CalvinWilkinson added the good-first-issue Good for newcomers label May 8, 2023
@CalvinWilkinson CalvinWilkinson removed their assignment May 8, 2023
@stale
Copy link

stale bot commented Jul 9, 2023

This issue has been automatically marked as stale due to the lack of activity for 60 days. The issue will be closed after 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Signifies that an issue is stale label Jul 9, 2023
@CalvinWilkinson CalvinWilkinson removed the stale Signifies that an issue is stale label Jul 9, 2023
@stale
Copy link

stale bot commented Sep 7, 2023

This issue has been automatically marked as stale due to the lack of activity for 60 days. The issue will be closed after 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Signifies that an issue is stale label Sep 7, 2023
@CalvinWilkinson CalvinWilkinson removed the stale Signifies that an issue is stale label Sep 9, 2023
@CalvinWilkinson CalvinWilkinson added the 🍺hacktoberfest-easy Easy issue for new developers for hacktoberfest!! Hack away!! label Oct 2, 2023
@thestbar
Copy link
Contributor

Hello, I would like to work on this! Please assign it to me!

@CalvinWilkinson
Copy link
Member

Absolutley!! If you have any questions, please don't hesitate to ask. I have a discord server as well that you can join and ask questions.

@CalvinWilkinson
Copy link
Member

The BufferManagerTests class does not need to be tested. This was removed in the release of v1.0.0-preview.15

@thestbar thestbar mentioned this issue Oct 13, 2023
Closed
@thestbar thestbar mentioned this issue Oct 13, 2023
Merged
1 task
@CalvinWilkinson CalvinWilkinson added this to the v1.0.0-preview.29 milestone Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thestbar thestbar

Labels
good-first-issue Good for newcomers 🍺hacktoberfest-easy Easy issue for new developers for hacktoberfest!! Hack away!! medium-priority Medium Priority preview Done while in preview tech-debt Code refactoring or cleanup / tech debt reduction
Projects
None yet
Milestone
v1.0.0-preview.29
Development

Successfully merging a pull request may close this issue.

🚧Refactor unit test assertions thestbar/Velaptor
3 participants
@thestbar @CalvinWilkinson @kselena