Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publishing order #16

Closed
rlnt opened this issue Jul 4, 2022 · 5 comments
Closed

publishing order #16

rlnt opened this issue Jul 4, 2022 · 5 comments

Comments

@rlnt
Copy link

rlnt commented Jul 4, 2022

Maybe a bit of an odd request but would it be possible to change the publishing order of the action?
I know I could make different steps by using the action multiple times but since CurseForge is down considerably more often than Modrinth, I'd like the action to try to publish to CF first so if that fails, the whole action fails and the release is canceled.

@Kir-Antipov
Copy link
Owner

This is not an odd request at all! I thought about this, but did not come up with a good solution how this could be expressed in the configuration. How do you see this feature yourself?

P.S. - also, I'm gonna change default order of publishers to CurseForge, Modrinth, and GitHub, because it actually makes sense

@rlnt
Copy link
Author

rlnt commented Jul 4, 2022

I would be more than happy with the new default order.
And if you want to make it a configurable option, I see the problem. The order would need to be defined in a list or an array of strings. I doubt the order of the config keys is the same within the workflow, otherwise, another approach would be taking the order of the tokens in the config.

So if you have:

mr_token: asdf
cf_token: asdf
github_token: asdf

it would use this publishing order.

@Kir-Antipov
Copy link
Owner

I would be more than happy with the new default order

The goal of this project is to be as zero-configy as possible, therefore, everything that makes sense to a lot of people will be converted into a feature here :)

I doubt the order of the config keys is the same within the workflow

Yep, that is the problem. GitHub actually converts all inputs to environment variables (e.g., name transforms into INPUT_NAME). And, to put it mildly, I am not sure that process.env respects the order of declaration of those variables

@rlnt
Copy link
Author

rlnt commented Jul 4, 2022

Hmm, I have no other idea then. The new default order would be fine I guess and if someone really wants to do it differently, they need to use multiple steps I guess.

@Kir-Antipov
Copy link
Owner

Yeah, makes sense. Let's keep it this way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants