Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DoubleWritesAnalyzer doesn't catch WriteLinesToFile #849

Open
ericstj opened this issue Jan 9, 2025 · 2 comments
Open

DoubleWritesAnalyzer doesn't catch WriteLinesToFile #849

ericstj opened this issue Jan 9, 2025 · 2 comments

Comments

@ericstj
Copy link

ericstj commented Jan 9, 2025

I noticed this in dotnet/sdk#45842

WriteLinesToFile seems like an easy one to add. There might be other commonly used Tasks that could be added to the analysis.
@baronfel
Copy link
Collaborator

It's worth checking this against the built in Buildcheck for double writes as well.

Cc @JanKrivanek

@JanKrivanek
Copy link
Collaborator

Yeah - there are couple others too: dotnet/msbuild#10439

This didn't meet the top priority bar. I'll try to find some spare time to add support for those.

FYI @YuliiaKovalova - we might consider adding (or swapping in) sdk as one of the repos for getting the usability info dotnet/msbuild#10726

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@baronfel @JanKrivanek @ericstj