Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

split_closed_faces should default to False and not allow None #253

Closed
greg-kcio opened this issue Aug 19, 2024 · 2 comments
Closed

split_closed_faces should default to False and not allow None #253

greg-kcio opened this issue Aug 19, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@greg-kcio
Copy link
Contributor

kittycad.models.input_format.step and kittycad.models.input_format.sldprt each have a new property split_closed_faces. They are Optional[bool] so they should accept True, False, or None, but assigning None causes the engine to return an error and close the websocket connection:

{'error_code': <ErrorCode.INVALID_BSON: 'invalid_bson'>, 'message': 'invalid type: unit value, expected a boolean'}
@greg-kcio greg-kcio added the bug Something isn't working label Aug 19, 2024
@greg-kcio
Copy link
Contributor Author

The error began after this PR: #246

@github-actions github-actions bot mentioned this issue Aug 26, 2024
Merged
@greg-kcio
Copy link
Contributor Author

Fixed by #254

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@greg-kcio