-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG]: Desktop app shows bad network until a project is opened #2610
Comments
The '-' actually means no connection yet - I think you could actually fix this quite easily looking in NetworkHealthIndicator (add a new state called 'Not started' and make it grey I guess). But yeah the alternative is starting engine immediately, which is probably best TBH. If the user forgets and never presses anything, our soon-to-be idle logic will kick in and kill the engine. Edit: additionally I'm not able to test this in our desktop app because Linux I'm currently working through ~350 type errors for the "throwing in frontend" issue, so, it will be awhile until I get to this issue. |
I can take this tomorrow |
will be setting up the mac mini and squashing this one in the current tauri stuff should be a small one |
maybe i can do it in a way that it translates over to the electron build |
Hey this might be able to be closed since I made the network health indicator hidden until the user is on the project view with #3393 |
Oh that works IMO |
yeah thats perfect |
Describe the bug
Presumably because the engine connection is not initialized until the first project is opened, the network health indicator shows a nebulous problem state until the user enters their first file. We will want tauri tests for this eventually.
Some solutions in my order of preference:
Steps to Reproduce
Expected Behavior
The network health indicator should only show a problem if there is a problem the user needs to address or that is otherwise interfering with app use.
Screenshots and Recordings
tauri tests playwright tests electron tests test
Desktop OS
Any
Browser
None (desktop version only)
Version
v0.22.0
Additional Context
@jessfraz this one might be borderline not high-priority: it's high visibility but low user impact.
The text was updated successfully, but these errors were encountered: