Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Desktop app shows bad network until a project is opened #2610

Closed
franknoirot opened this issue Jun 5, 2024 · 7 comments
Closed

[BUG]: Desktop app shows bad network until a project is opened #2610

franknoirot opened this issue Jun 5, 2024 · 7 comments
Assignees
Labels
bug Something isn't working connection For all things involving websockets/webrtc and connection to the engine. design Design related issues desktop-app Issues from the desktop app. high-priority

Comments

@franknoirot
Copy link
Collaborator

franknoirot commented Jun 5, 2024

Describe the bug

Presumably because the engine connection is not initialized until the first project is opened, the network health indicator shows a nebulous problem state until the user enters their first file. We will want tauri tests for this eventually.

Some solutions in my order of preference:

  1. Connect to the engine on app start up. I think this would have the knock-on effect of making first project load faster too.
  2. Make the network health indicator only check the validity of network connected status until the engine connection is attempted.
  3. Hide the network connection on home page

Steps to Reproduce

  1. Open the desktop app

Expected Behavior

The network health indicator should only show a problem if there is a problem the user needs to address or that is otherwise interfering with app use.

Screenshots and Recordings

Screenshot 2024-06-05 at 1 19 43 PM

tauri tests playwright tests electron tests test

Desktop OS

Any

Browser

None (desktop version only)

Version

v0.22.0

Additional Context

@jessfraz this one might be borderline not high-priority: it's high visibility but low user impact.

@franknoirot franknoirot added the bug Something isn't working label Jun 5, 2024
@franknoirot franknoirot added this to the v1 Modeling App Launch milestone Jun 5, 2024
@franknoirot franknoirot added connection For all things involving websockets/webrtc and connection to the engine. design Design related issues labels Jun 5, 2024
@lf94
Copy link
Contributor

lf94 commented Jun 5, 2024

The '-' actually means no connection yet - I think you could actually fix this quite easily looking in NetworkHealthIndicator (add a new state called 'Not started' and make it grey I guess). But yeah the alternative is starting engine immediately, which is probably best TBH. If the user forgets and never presses anything, our soon-to-be idle logic will kick in and kill the engine.

Edit: additionally I'm not able to test this in our desktop app because Linux

I'm currently working through ~350 type errors for the "throwing in frontend" issue, so, it will be awhile until I get to this issue.

@lf94
Copy link
Contributor

lf94 commented Aug 4, 2024

I can take this tomorrow

@lf94 lf94 self-assigned this Aug 4, 2024
@lf94
Copy link
Contributor

lf94 commented Aug 6, 2024

will be setting up the mac mini and squashing this one in the current tauri stuff should be a small one

@lf94
Copy link
Contributor

lf94 commented Aug 6, 2024

maybe i can do it in a way that it translates over to the electron build

@franknoirot
Copy link
Collaborator Author

Hey this might be able to be closed since I made the network health indicator hidden until the user is on the project view with #3393

@lf94
Copy link
Contributor

lf94 commented Aug 20, 2024

Oh that works IMO

@jessfraz
Copy link
Contributor

yeah thats perfect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working connection For all things involving websockets/webrtc and connection to the engine. design Design related issues desktop-app Issues from the desktop app. high-priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants