Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Keyboard shortcut to open command palette collides in Firefox #3000

Closed
jtran opened this issue Jul 10, 2024 · 1 comment
Closed

[BUG]: Keyboard shortcut to open command palette collides in Firefox #3000

jtran opened this issue Jul 10, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@jtran
Copy link
Collaborator

jtran commented Jul 10, 2024

Describe the bug

In Firefox, Command+K focuses on the search bar. I ran into this the first time I used the modeling app because the tour on first use tells you to press the shortcut.

If we use Command+K, we should not also do the browser's default, i.e. we should make sure we're calling event.preventDefault().

Alternatively, we could use a different shortcut. Command+Shift+P is the default for the command palette in both Sublime Text and VS Code.

Steps to Reproduce

  1. Open the app in Firefox
  2. Press the keyboard shortcut for the command palette: Command+K or Ctrl+K

Expected Behavior

I expect the command palette to open. Instead, it opens, but also the Firefox search bar opens and moves the keyboard focus there.

Screenshots and Recordings

Screenshot 2024-07-10 at 6 09 48 PM

Desktop OS

macOS 14.6

Browser

Firefox

Version

127

Additional Context

No response

@jtran jtran added the bug Something isn't working label Jul 10, 2024
@jessfraz
Copy link
Contributor

closing since firefox wont be a priority or supported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants