Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron tests: network machines (on the tougher side) #3368

Closed
lf94 opened this issue Aug 12, 2024 · 1 comment · Fixed by #3534
Closed

Electron tests: network machines (on the tougher side) #3368

lf94 opened this issue Aug 12, 2024 · 1 comment · Fixed by #3534
Assignees
Labels
desktop-app Issues from the desktop app. tests Pull requests that update or improve our test suite

Comments

@lf94
Copy link
Contributor

lf94 commented Aug 12, 2024

This is a tough one. We will require a sort of "dummy" mdns service to broadcast it's a 3D printer or CNC machine during the tests.

The tests should:

  1. Show zero network machines by default
    out

  2. Show 2 network machines when there are 2 on the network.

  3. Show 1 network machine when 1/2 go offline.

@lf94
Copy link
Contributor Author

lf94 commented Aug 12, 2024

@paultag or @jessfraz I'm sure there's stuff I'm missing here but I've not had a chance to really touch this feature outside of just seeing that icon. Please modify issue description to add any more.

@jessfraz jessfraz added tests Pull requests that update or improve our test suite desktop-app Issues from the desktop app. labels Aug 12, 2024
@jessfraz jessfraz self-assigned this Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop-app Issues from the desktop app. tests Pull requests that update or improve our test suite
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants