Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggling Dismiss Web Banner on Project Level not working #3493

Closed
ZooSpiritWolf opened this issue Aug 16, 2024 · 1 comment
Closed

Toggling Dismiss Web Banner on Project Level not working #3493

ZooSpiritWolf opened this issue Aug 16, 2024 · 1 comment
Assignees
Labels
bug Something isn't working regression Bugs related to regressions.

Comments

@ZooSpiritWolf
Copy link

🐛 on Dev

Steps to reproduce:

  1. Login
  2. Navigate to "User Settings"
  3. Click on "This project"
  4. Toggle Dismiss Web Banner setting on
  5. Refresh
    Expected:
    Web banner should not pop up on reload
    Actual:
    Web banner pops up on reload
    Video:
    https://www.loom.com/share/40c1c71cc5924d9fb5dfb4fdebffed7a?sid=42be6696-80f4-4de1-9bae-9c27b0320ca2 (https://www.loom.com/share/40c1c71cc5924d9fb5dfb4fdebffed7a?sid=42be6696-80f4-4de1-9bae-9c27b0320ca2)

Bug report:
https://app.qawolf.com/zoo/bug-reports/7356adce-c360-48e8-9487-22bc55c27612

Affected workflows:
• App - Toggle Dismiss Web Banner - https://app.qawolf.com/zoo/workflows/clweyigd50cczzn90xp6tabv1

If you are aware of this bug you can set the priority to low which will prevent it from causing a run failure.

@jessfraz jessfraz added bug Something isn't working regression Bugs related to regressions. labels Aug 16, 2024
@franknoirot franknoirot self-assigned this Aug 20, 2024
@franknoirot
Copy link
Collaborator

This has been fixed in a previous PR without being directly worked on. I believe it was as a corollary of #3584, since it dealt with our settings parsing and level override logic.

For that same reason, I believe no new tests beyond those which deal with the project-level settings being able to override lower-priority values are needed, as it is the same system which governs this warning popup. So I am closing this as complete without any PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working regression Bugs related to regressions.
Projects
None yet
Development

No branches or pull requests

3 participants