Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

double click to open files from explorer/ app.exe path/to/kcl/file/or/dir should open in app #3577

Closed
jessfraz opened this issue Aug 20, 2024 · 9 comments · Fixed by #3643
Closed

double click to open files from explorer/ app.exe path/to/kcl/file/or/dir should open in app #3577

jessfraz opened this issue Aug 20, 2024 · 9 comments · Fixed by #3643
Assignees
@jessfraz

Comments

@jessfraz
Copy link
Contributor

jessfraz commented Aug 20, 2024 •
edited
Loading

there are a bunch of tests here for various weird shit https://github.com/KittyCAD/modeling-app/blob/main/src/wasm-lib/kcl/src/settings/types/file.rs#L539

like app.exe . should open the curdir
@jessfraz jessfraz mentioned this issue Aug 21, 2024
Open
15 tasks
@jessfraz
Copy link
Contributor Author

more data https://github.com/microsoft/vscode/blob/main/src/main.js#L543

@jessfraz
Copy link
Contributor Author

windows uses process.argv

@Irev-Dev
Copy link
Collaborator

What are you thinking for how to do these tests?
Bash scripts kinda thing?

@jessfraz
Copy link
Contributor Author

No manual but right now this doesn’t work

@jessfraz
Copy link
Contributor Author

Which is the issue

@jessfraz
Copy link
Contributor Author

And people use this feature now so we can’t skip it

@jessfraz
Copy link
Contributor Author

Like I don’t think lee hooked it up at all

@jessfraz jessfraz self-assigned this Aug 23, 2024
@jessfraz
Copy link
Contributor Author

ill take this one since i know all the weird bits from tauri

@Irev-Dev
Copy link
Collaborator

Oh sorry I just assumed test, cool sounds good.

@jessfraz jessfraz mentioned this issue Aug 23, 2024
Merged
@github-actions github-actions bot mentioned this issue Aug 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jessfraz jessfraz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

double-click to open / open from cli KittyCAD/modeling-app
2 participants
@jessfraz @Irev-Dev