Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this library compatible with React 19? #453

Open
jgarplind opened this issue Jan 5, 2025 · 2 comments
Open

Is this library compatible with React 19? #453

jgarplind opened this issue Jan 5, 2025 · 2 comments

Comments

@jgarplind
Copy link

Is this library compatible with React 19?

I don't see any instant reason why not, so I would submit a PR bumping the peer dependency to v19, but that is assuming that there is nothing breaking that I'm not aware of.

If you want to give it a look yourself and are not fully up to speed, here's a helpful resource to evaluate the (not so big in my opinion) breaking changes: https://react.dev/blog/2024/04/25/react-19-upgrade-guide#breaking-changes

@KittyGiraudel
Copy link
Owner

Hello Joel,

That is a good question! My gut feeling is that it should be, but it would need to be tried out. If you have capacity to give it a go, and everything works, then feel free to bump the peer dep. :)

@techbridgedev
Copy link

techbridgedev commented Jan 7, 2025

At present it throws an error because React 19 isn't listed as an option in the peer dependencies.

npm error Could not resolve dependency:
npm error peer react@"^16.8.0 || ^17 || ^18" from react-a11y-dialog@7.4.0
npm error node_modules/react-a11y-dialog
npm error   react-a11y-dialog@"^7.4.0" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.

I'm using this package on Docusaurus. Docusuarus 4 will require React 19, at which point this package will become incompatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants