Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(plotly): fix example, height must be within [0,inf] #604

Closed
wants to merge 1 commit into from

Conversation

bourdaisj
Copy link
Contributor

had a crash when I tried the example. This fixes it. Probably an update in the python plotly package in the meantime.

@bourdaisj bourdaisj requested a review from jourdain October 4, 2024 10:02
@bourdaisj bourdaisj marked this pull request as draft October 4, 2024 10:07
@bourdaisj
Copy link
Contributor Author

marked as draft: might me more things to be fixed

@jourdain
Copy link
Collaborator

jourdain commented Oct 4, 2024

Fixed it here 0fd5bd0

@bourdaisj bourdaisj marked this pull request as ready for review October 5, 2024 17:54
@bourdaisj
Copy link
Contributor Author

then we can merge I guess

@jourdain
Copy link
Collaborator

jourdain commented Oct 9, 2024

But that is not really required, or is it?

@bourdaisj bourdaisj closed this Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants