perf(viewnode): speedup getViewNodeFor

Provide the previously found view node to avoid a full search each time
a prepass of buildPass is done

issue #3351

Author: finetjul

Sources/Rendering/OpenGL/HardwareSelector/index.js

@@ -341,7 +341,8 @@ function vtkOpenGLHardwareSelector(publicAPI, model) {
   //----------------------------------------------------------------------------
   publicAPI.beginSelection = () => {
     model._openGLRenderer = model._openGLRenderWindow.getViewNodeFor(
-      model._renderer
+      model._renderer,
+      model._openGLRenderer
     );
     model.maxAttributeId = 0;
 
@@ -459,7 +460,8 @@ function vtkOpenGLHardwareSelector(publicAPI, model) {
     }
 
     model._openGLRenderer = model._openGLRenderWindow.getViewNodeFor(
-      model._renderer
+      model._renderer,
+      model._openGLRenderer
     );
 
     // todo revisit making selection part of core

Sources/Rendering/OpenGL/ImageCPRMapper/index.js

@@ -61,7 +61,8 @@ function vtkOpenGLImageCPRMapper(publicAPI, model) {
       }
       model.context = model._openGLRenderWindow.getContext();
       model.openGLCamera = model._openGLRenderer.getViewNodeFor(
-        model._openGLRenderer.getRenderable().getActiveCamera()
+        model._openGLRenderer.getRenderable().getActiveCamera(),
+        model.openGLCamera
       );
 
       model.tris.setOpenGLRenderWindow(model._openGLRenderWindow);

Sources/Rendering/OpenGL/ImageMapper/index.js

@@ -91,7 +91,8 @@ function vtkOpenGLImageMapper(publicAPI, model) {
       model.tris.setOpenGLRenderWindow(model._openGLRenderWindow);
       const ren = model._openGLRenderer.getRenderable();
       model.openGLCamera = model._openGLRenderer.getViewNodeFor(
-        ren.getActiveCamera()
+        ren.getActiveCamera(),
+        model.openGLCamera
       );
       // is slice set by the camera
       if (

Sources/Rendering/OpenGL/ImageResliceMapper/index.js

@@ -113,7 +113,8 @@ function vtkOpenGLImageResliceMapper(publicAPI, model) {
         publicAPI.getFirstAncestorOfType('vtkOpenGLRenderer');
       const ren = model._openGLRenderer.getRenderable();
       model._openGLCamera = model._openGLRenderer.getViewNodeFor(
-        ren.getActiveCamera()
+        ren.getActiveCamera(),
+        model.openGLCamera
       );
       const oldOglRenderWindow = model._openGLRenderWindow;
       model._openGLRenderWindow = model._openGLRenderer.getLastAncestorOfType(

Sources/Rendering/OpenGL/PolyDataMapper/index.js

@@ -60,7 +60,8 @@ function vtkOpenGLPolyDataMapper(publicAPI, model) {
         'vtkOpenGLRenderWindow'
       );
       model.openGLCamera = model._openGLRenderer.getViewNodeFor(
-        model._openGLRenderer.getRenderable().getActiveCamera()
+        model._openGLRenderer.getRenderable().getActiveCamera(),
+        model.openGLCamera
       );
     }
   };

Sources/Rendering/OpenGL/PolyDataMapper2D/index.js

@@ -41,7 +41,8 @@ function vtkOpenGLPolyDataMapper2D(publicAPI, model) {
         'vtkOpenGLRenderWindow'
       );
       model.openGLCamera = model._openGLRenderer.getViewNodeFor(
-        model._openGLRenderer.getRenderable().getActiveCamera()
+        model._openGLRenderer.getRenderable().getActiveCamera(),
+        model.openGLCamera
       );
     }
   };

Sources/Rendering/OpenGL/Skybox/index.js

@@ -31,7 +31,8 @@ function vtkOpenGLSkybox(publicAPI, model) {
       model.openGLTexture.setOpenGLRenderWindow(model._openGLRenderWindow);
       const ren = model._openGLRenderer.getRenderable();
       model.openGLCamera = model._openGLRenderer.getViewNodeFor(
-        ren.getActiveCamera()
+        ren.getActiveCamera(),
+        model.openGLCamera
       );
     }
   };

Sources/Rendering/OpenGL/VolumeMapper/index.js

@@ -162,7 +162,8 @@ function vtkOpenGLVolumeMapper(publicAPI, model) {
         publicAPI.getFirstAncestorOfType('vtkOpenGLRenderer');
       const ren = model._openGLRenderer.getRenderable();
       model.openGLCamera = model._openGLRenderer.getViewNodeFor(
-        ren.getActiveCamera()
+        ren.getActiveCamera(),
+        model.openGLCamera
       );
       publicAPI.renderPiece(ren, actor);
     }

Sources/Rendering/SceneGraph/ViewNode/index.d.ts

@@ -100,8 +100,9 @@ export interface vtkViewNode extends vtkObject {
    * Returns the view node that corresponding to the provided object
    * Will return NULL if a match is not found in self or descendents
    * @param dataObject
+   * @param [hint] the previously found node (for optimization)
    */
-  getViewNodeFor(dataObject: any): any;
+  getViewNodeFor(dataObject: any, hint?: any): any;
 
   /**
    *

Sources/Rendering/SceneGraph/ViewNode/index.js

@@ -45,7 +45,11 @@ function vtkViewNode(publicAPI, model) {
     }
   };
 
-  publicAPI.getViewNodeFor = (dataObject) => {
+  publicAPI.getViewNodeFor = (dataObject, hint = null) => {
+    if (hint && hint.renderable === dataObject) {
+      return hint;
+    }
+
     if (model.renderable === dataObject) {
       return publicAPI;
     }