Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[translations] Try SWC plugin for lingui, remove babel #922

Closed
4 of 5 tasks
Atmosfearful opened this issue Feb 1, 2023 · 2 comments
Closed
4 of 5 tasks

[translations] Try SWC plugin for lingui, remove babel #922

Atmosfearful opened this issue Feb 1, 2023 · 2 comments
Assignees

Comments

@Atmosfearful
Copy link
Collaborator

Atmosfearful commented Feb 1, 2023

New lingui swc-plugin https://github.com/lingui/swc-plugin

SWC should give us faster builds. https://nextjs.org/docs/advanced-features/compiler#why-swc

Preliminary research

  • aside from lingui, what else needs babel? Can we remove @emotion/babel-plugin?

Todos

  • npm install the lingui swc plugin it for app and site
  • Using the swcPlugins field in next.config.js update config to use the swc lingui plugin for app and site
  • delete babel config and any other babel stuff
  • see if the builds are faster and document the difference in speed (I can provide vercel access to view builds)
@biwano
Copy link
Collaborator

biwano commented Apr 24, 2023

@Atmosfearful If we are still doing this, I need to add the code to carbonmark too.

@jabby09 jabby09 changed the title Try SWC plugin for lingui, remove babel [translations] Try SWC plugin for lingui, remove babel Apr 24, 2023
@Atmosfearful
Copy link
Collaborator Author

This was tested here #927
But no significant speedup was detected so we will stick with the tried-and-tested babel builds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants