Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in import: Sometimes empty values are resolved as 0, which is wrong and causes problems #526

Closed
Greenheart opened this issue Dec 18, 2024 · 0 comments · Fixed by #560
Labels
bug Something isn't working

Comments

@Greenheart
Copy link
Collaborator

Greenheart commented Dec 18, 2024

We should verify if values are numeric, and that the string representation of the cell value has some content.
Alternatively, check if the numeric value is 0, then the string value of the cell must also be explicitly "0", otherwise we should treat the value as undefined or null.

Instead of resolving this in the import script, we should probably double-check in the production DB (and potentially remove) all 0 values imported via the script. We could use the timestamp and the verifiiedBy, and potentially comment to find all occurences of this problem, and fix them manually via the API / editor.

@Greenheart Greenheart added the bug Something isn't working label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant