Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One of the Partner SVGs has a surprisingly large filesize #526

Open
JohanLi opened this issue May 8, 2024 · 2 comments
Open

One of the Partner SVGs has a surprisingly large filesize #526

JohanLi opened this issue May 8, 2024 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed ready This is ready to be implemented

Comments

@JohanLi
Copy link
Contributor

JohanLi commented May 8, 2024

Most of them are under 5 kBs after compression, but one of them is a whopping 132 kBs.

If it's easy to get the SVGs content hashed, it might be worth improving the current Cache-Control from public, max-age=0, must-revalidate to public,max-age=31536000,immutable (existing JS + CSS).

image
@Greenheart
Copy link
Collaborator

Yeah this was an interesting find!

Feel free to open an issue for your other idea about the location based info from vercel/IP info too 😊

@JohanLi
Copy link
Contributor Author

JohanLi commented May 8, 2024

Feel free to open an issue for your other idea about the location based info from vercel/IP info too 😊

Done! #531

@elvbom elvbom added enhancement New feature or request help wanted Extra attention is needed labels May 20, 2024
@elvbom elvbom moved this to Ready in Klimatkollen web May 20, 2024
@elvbom elvbom added the ready This is ready to be implemented label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed ready This is ready to be implemented
Projects
Status: Ready
Development

No branches or pull requests

3 participants