Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove enable_lifespan parameter (deprecated) #109

Closed
jordaneremieff opened this issue May 15, 2020 · 2 comments
Closed

Remove enable_lifespan parameter (deprecated) #109

jordaneremieff opened this issue May 15, 2020 · 2 comments
Labels
chore Maintenance task

Comments

@jordaneremieff
Copy link
Collaborator

jordaneremieff commented May 15, 2020 •
edited
Loading

The enable_lifespan field was deprecated as part of #108. It is being replaced with a lifespan option that can be set to "auto", "on", "off" (similar to Uvicorn's parameter).

Since it was included in many examples and documentation I will likely not remove it for awhile. Probably in 0.10.0, but maybe later.
@jordaneremieff jordaneremieff added improvement Improve an existing feature chore Maintenance task and removed improvement Improve an existing feature labels May 15, 2020
@jordaneremieff
Copy link
Collaborator Author

This will be removed as part of whichever release includes #86

@jordaneremieff
Copy link
Collaborator Author

Removed here. Will raise an error in 0.10.1.

@dustye dustye mentioned this issue Apr 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore Maintenance task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jordaneremieff