Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log output understanding question #159

Closed
mobilutz opened this issue Sep 8, 2021 · 4 comments
Closed

Log output understanding question #159

mobilutz opened this issue Sep 8, 2021 · 4 comments
Assignees
Labels

Comments

@mobilutz
Copy link

mobilutz commented Sep 8, 2021

I am seeing output from this line in our CI logs, and want to know what it means:

If you need to reproduce a particular subset of tests fetched from API queue then above after each request to Knapsack Pro API you will find example rspec command.

It comes form here:

KnapsackPro.logger.info("To retry in development the tests for this CI node please run below command on your machine. It will run all tests in a single run. If you need to reproduce a particular subset of tests fetched from API queue then above after each request to Knapsack Pro API you will find example rspec command.")

There seems to be something wrong with this sentence, especially here:
... fetched from API queue then above after each request ...

I would like to support, but I don't know what exactly this sentence means.

@shadre
Copy link
Member

shadre commented Sep 8, 2021

@mobilutz thanks for raising the issue. 👍 The bit you quoted is referring to other messages that come from L113 in the same file. Basically, the command displayed below the message you are quoting would run all the test files assigned to a particular CI node, while the previous commands run just subsets of those (as retrieved from the API queue on each request).

We agree the turn of phrase is not particularly legible there. I'm going to prepare a change for this shortly. :-)

@shadre shadre self-assigned this Sep 8, 2021
@mobilutz
Copy link
Author

mobilutz commented Sep 8, 2021

The bit you quoted is referring to other messages that come from L113 in the same file.

Doesn't the case statement prevent the output of L113 and L115 at the same time?

But 👍🏻 and thanks on a wording change to make it more understandable!

@shadre
Copy link
Member

shadre commented Sep 8, 2021

Doesn't the case statement prevent the output of L113 and L115 at the same time?

Yes, it does. However, we expect this code to usually be run multiple times in the Queue Mode, resulting in multiple outputs (with the one from L115 coming last) - hence the reference to the commands "above". :-)

@ArturT
Copy link
Member

ArturT commented Sep 10, 2021

@mobilutz We've released a new knapsack_pro version 3.1.1 with updated messages.

@ArturT ArturT closed this as completed Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants