Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom minitest reporter is run once on the first split, twice on the second, ..., N times on the Nth split #264

Open
davidwessman opened this issue Jun 24, 2024 · 1 comment
Labels

Comments

@davidwessman
Copy link

Command: bundle exec rake knapsack_pro:queue:minitest
Version: knapsack_pro 7.6.1
Test runner: Github Actions
Minitest version: 5.24.0

We are using https://blinka.app (my own tool) to report test results to the PR as a comment.
This is the minitest plugin:
https://github.com/davidwessman/blinka_reporter/blob/main/lib/minitest/blinka_plugin.rb

For the 1-2 weeks we sometimes get more tests that we are actually running, that is when I realized it looked like this:

Screenshot 2024-06-24 at 13 18 00

Did anything change with the Minitest runner? Or something with Minitest itself?

Maybe I need to update something with my plugin as well.

Here seems to be some change regarding plugins.
minitest/minitest@2c5f1b7

@ArturT
Copy link
Member

ArturT commented Jun 25, 2024

Do you use simplecov with Minitest? If so, we recently discovered a breaking change in the knapsack_pro 6.0.4 version. You can find here info on how to adjust your project.

I think there were no other changes.

Please note that in Queue Mode, tests are executed at least once. For example, if one of parallel CI nodes can't connect to the Knapsack Pro API, then it would run tests in fallback mode which means the same test could be executed on multiple nodes.

Could you provide a link to the CI build in the Knapsack Pro dashboard?

You can set KNAPSACK_PRO_LOG_LEVEL=debug and when the issue happens again please send a txt output from CI to support@knapsackpro.com. I'd like to investigate that. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants