Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

Improve UX when user try to create PR from unpublish branch #78

Closed
guillaumemolter opened this issue Mar 21, 2017 · 2 comments
Closed

Comments

@guillaumemolter
Copy link

guillaumemolter commented Mar 21, 2017

Currently if you hit "Create PR" on an unpublished branch...
screen shot 2017-03-20 at 14 57 35
...you get the following error message...
screen shot 2017-03-20 at 14 57 22
...which is not very clear and can be really confusing for none power users.

Here are 4 ways this could be improved, I think the first option is the best but it is also clearly the one that requires the most work:

  1. When clicking on create PR from an unpublished branch, user should receive a notification "Your branch needs to be published before you can create a PR [Publish and Create PR] [Cancel]"
  2. The current error message should be replaced by something more verbose "You need to publish your branch before you can create a PR"
  3. We could assume that it is obvious and simply publish automatically without prompt and then create the PR.
  4. The Create PR button should be greyed out when the branch is not published.
@KnisterPeter
Copy link
Owner

Duplicate of #61

@KnisterPeter
Copy link
Owner

Good ideas, I've referenced them so they are linked from the bug report

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants