Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation causes temporary flicker to invalid state CSS #673

Open
hlascelles opened this issue Oct 25, 2019 · 0 comments
Open

Validation causes temporary flicker to invalid state CSS #673

hlascelles opened this issue Oct 25, 2019 · 0 comments

Comments

@hlascelles
Copy link
Contributor

When tabbing out of a valid field (and the field moves from isModified false => true), calls are made to the css handler that temporarily put it into an invalid state.

The changed that caused this was this one, where the function declaration order of the h_obsValidationTrigger and setError functions are reversed.

This is demonstrated in a simple JSFiddle here: https://jsfiddle.net/hlascelles/3Lz5ug8x/9/

The symptom is that any triggers/hooks that listen for DOM changes or CSS changes will fire even though the user did nothing wrong. In the example, this is shown using a CSS transition, which causes a form flicker.

Why was the method order reversed in that other PR? Could it be changed back?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant