Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics support at the application configuration level #21

Open
malaskowski opened this issue Dec 17, 2019 · 0 comments
Open

Metrics support at the application configuration level #21

malaskowski opened this issue Dec 17, 2019 · 0 comments

Comments

@malaskowski
Copy link
Member

malaskowski commented Dec 17, 2019

Context
Enable metrics configuration from the Knot.x configuration.

Describe the solution you'd like
Vert.x enables metrics via SPI (there are numerous implementations like Dropwizard or Micrometer).
Enabling the metrics is configured when the Vert.x instance starts (that's the only way to pass the MetricsOptions to the Vert.x instance). One way to enable metrics is actually pas those options via command line, however this is not very intuitive way.
A one lot better would be to pass all necessary configs (including specific ones for the metrics SPI provider) via HOCON configuration, e.g.

metrics {
  enabled = true
  config {
    name = micrometer
    config {
      //specific config
    }
  }
}

Describe alternatives you've considered
There is actually an alternative implemented, which is Knot.x Dropwizard Metrics module. However, it is kind of hacky, and assumes that metrics are already enabled and some Dropwizard registry exists.

Additional context
It would be great if the configuration enables to run Hystrix Dashboard that shows current circuit breaker status.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant