Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It doesn't work with Symfony 3.0.0 #39

Open
XavierKoma opened this issue Dec 23, 2015 · 3 comments
Open

It doesn't work with Symfony 3.0.0 #39

XavierKoma opened this issue Dec 23, 2015 · 3 comments

Comments

@XavierKoma
Copy link

Impossible to install the bundle with composer : php composer.phar require knplabs/knp-disqus-bundle:dev-master

@weaverryan
Copy link
Contributor

Indeed we need to update this! If someone has time to update the composer.json file and .travis.yml so that it tests all versions, that would be HUGE. Good examples to follow are on KnpMenuBundle: https://github.com/KnpLabs/KnpMenuBundle/blob/master/composer.json and https://github.com/KnpLabs/KnpMenuBundle/blob/master/.travis.yml

@shairyar
Copy link

shairyar commented Feb 3, 2016

Really wanted to use this, in composer.json what exactly needs to be updated other than

"symfony/framework-bundle": "~2.3|~3.0"

@weaverryan
Copy link
Contributor

See #40 - we just need to see what changes to .travis.yml or composer.json need to be made to make the tests pass. If you're able to help debug those, that would help that :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants