Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSO service is overwritten #46

Open
dantleech opened this issue Jan 24, 2018 · 2 comments · May be fixed by #47
Open

SSO service is overwritten #46

dantleech opened this issue Jan 24, 2018 · 2 comments · May be fixed by #47

Comments

@dantleech
Copy link

It seems the $parameters['sso']['service'] is overwritten here, and the generated value from getSsoParameters does not include the service.
@dantleech
Copy link
Author

Specifically the Disqus class will only include the existing sso parameters if the user config key is set - and in our application (and any other?) we only set this key if the user is logged in.

The SSO service should be set regardless of logged in status.

@weaverryan
Copy link
Contributor

Dan - do you have a fix you could propose? Nobody super maintains this bundle, but I’d certainly be happy to merge a pr and tag.

@dantleech dantleech linked a pull request Jan 25, 2018 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure SSO 'service' is not overwritten dantleech/KnpDisqusBundle
2 participants
@weaverryan @dantleech