Add support for SSO errors coming from the API #913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As a reference, here are some docs referencing this header and how to use it: https://developer.github.com/v3/auth/#authenticating-for-saml-sso |
|
Looks good @eiriksm! Can you apply the suggested changes from styleci and add a test for the new exception logic? Thanks! |
|
Added a test and got styleCI passing 🚢 |
acrobat
approved these changes
Aug 15, 2020
|
Thanks @eiriksm! And congrats on your first contribution! 🎉 |
acrobat
added a commit
that referenced
this pull request
Oct 5, 2020
* 2.x: Add OutsideCollaborators api Fix: Wrong PHPDoc description feature #913 Add support for SSO errors coming from the API (eiriksm)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, thanks for this!
I just had a case where a token I used were throwing a runtimeexception because the org in question for the resource, had enforced SAML authentication. This was not something I could explicitly catch and do something with, so here is a PR fixing that.
Thanks again, keep up the good work!