Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: JSDoc 3.6+ and Markdown plugin support #246

Merged
merged 7 commits into from
Aug 1, 2019
Merged

fix: JSDoc 3.6+ and Markdown plugin support #246

merged 7 commits into from
Aug 1, 2019

Conversation

Kocal
Copy link
Owner

@Kocal Kocal commented Jul 31, 2019 •
edited
Loading

Render is actually broken in JSDoc 3.6+:
Capture d’écran de 2019-07-31 22-12-13

@Kocal Kocal force-pushed the fix/jsdoc-3.6.3-support branch 5 times, most recently from 2214473 to 7477f6f Compare July 31, 2019 19:01
@Kocal Kocal force-pushed the fix/jsdoc-3.6.3-support branch from 7477f6f to 529d42e Compare July 31, 2019 20:11
@Kocal Kocal changed the title WIP: JSDoc 3.6.3+ support WIP: JSDoc 3.6+ support Jul 31, 2019
@Kocal Kocal changed the title WIP: JSDoc 3.6+ support WIP: JSDoc 3.6+ and Markdown plugin support Jul 31, 2019
@Kocal
Copy link
Owner Author

Kocal commented Jul 31, 2019

There is no issue anymore when disabling Markdown plugin.

@Kocal
Copy link
Owner Author

Kocal commented Jul 31, 2019

Issue opened jsdoc/jsdoc#1668

@Kocal Kocal force-pushed the fix/jsdoc-3.6.3-support branch from ad2ee43 to ec5d0cb Compare August 1, 2019 04:33
@Kocal Kocal force-pushed the fix/jsdoc-3.6.3-support branch from ec5d0cb to d070405 Compare August 1, 2019 04:50
@codecov-io
Copy link

codecov-io commented Aug 1, 2019 •
edited
Loading

Codecov Report

Merging #246 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #246   +/-   ##
=======================================
  Coverage   70.83%   70.83%           
=======================================
  Files           5        5           
  Lines          48       48           
  Branches       11       11           
=======================================
  Hits           34       34           
  Misses         11       11           
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3591c8a...d07eebc. Read the comment docs.

@cypress
Copy link

cypress bot commented Aug 1, 2019 •
edited
Loading


Test summary

42 • 0 • 0 • 0

Run details
Project jsdoc-vuejs
Status Timedout
Commit 1b7a0f6
Started Aug 1, 2019 5:11 AM
Ended Aug 1, 2019 7:14 AM
Duration 03:39 💡
OS Windows 6.3.9600
Browser Electron 61

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@Kocal Kocal changed the title WIP: JSDoc 3.6+ and Markdown plugin support fix: JSDoc 3.6+ and Markdown plugin support Aug 1, 2019
@Kocal Kocal merged commit 27e3bc7 into master Aug 1, 2019
@Kocal Kocal deleted the fix/jsdoc-3.6.3-support branch August 1, 2019 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kocal @codecov-io