Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kha.khaPath is not resolved correctly #45

Open
sh-dave opened this issue Sep 25, 2017 · 5 comments
Open

kha.khaPath is not resolved correctly #45

sh-dave opened this issue Sep 25, 2017 · 5 comments

Comments

@sh-dave
Copy link

sh-dave commented Sep 25, 2017

kha.khaPath is not resolved correctly when you use it in the workspace settings file (PROJECT/.vscode/settings) AND when you try to do a launch build (F5).

Works ok in the user settings file or when building via target selector (> Compile Kha Project)

KS: windows 17.9.1

@sh-dave
Copy link
Author

sh-dave commented Dec 7, 2017

I think this comes from here, as it only looks in the .user section of the config and should probably be this.getConfiguration('kha.khaPath') or something?

https://github.com/Kode/KodeStudio/blob/master/src/vs/workbench/services/configuration/node/configuration.ts#L505

@gluks
Copy link

gluks commented Mar 1, 2018

in my case kha.khaPath is ignored
I added the value to
PROJECT/.vscode/settings.json
and to
%appdata%/Roaming/Kode Studio/User/settings.json

but none of these worked and default version of kha is used
KS 17.9.1
windows 7 x64

@sh-dave
Copy link
Author

sh-dave commented Mar 1, 2018

For user settings (the one in appdata) it should at least work if you use an absolute path say:

"kha.khaPath": "d:/dev/kode/kha",

@gluks
Copy link

gluks commented Mar 1, 2018

Finally it worked. Seems that it was my fault... I have too many versions of kha installed =)

@sh-dave
Copy link
Author

sh-dave commented Mar 1, 2018

I usually just add it as submodule in my projects, so it's properly versioned and automatically picked up by KodeStudio. Takes some more space on the drives, but it's much less trouble imo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants