Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password with special characters #24

Closed
Master-Silver opened this issue Jul 9, 2021 · 7 comments
Closed

Password with special characters #24

Master-Silver opened this issue Jul 9, 2021 · 7 comments
Assignees

Comments

@Master-Silver
Copy link

The login over this Api on the UniFi controller will fail, when the used password contains a ". Not exactly sure why it fails, but UniFi allows such passwords.

@Master-Silver Master-Silver added the Reviewing Item is being reviewed label Jul 9, 2021
@Master-Silver Master-Silver changed the title [BUG] Brief description Password with special characters Jul 9, 2021
@KoenZomers
Copy link
Owner

Thanks for reporting! That should be easy enough to reproduce and fix. I'll look into it.

@KoenZomers KoenZomers added investigating and removed Reviewing Item is being reviewed labels Jul 10, 2021
@KoenZomers
Copy link
Owner

The dot doesn't seem to be the issue. Are there more special characters in the password? I'll try some of those.

@KoenZomers
Copy link
Owner

Also that seems to work well. I.e. I created a temporary account with the password Jemsf%_&Sk#fek.34324 and it authenticated without any problems. Can you provide more information on what exactly goes wrong and against what kind of UniFi controller you are authenticating? Is it self hosted, cloud hosted, cloud key, which version, etc?

@Master-Silver
Copy link
Author

Jemsf%_&Sk#fek.34324

does not contain any quotation mark (" or '). I had trouble with a password that contains quotation marks. I think it has to do with the escaping before sending the login details per Json to the controller.
I have a self hosted controller, but the login worked in the browser just not with the API. I also checked my code with the debugger, the password was correct before sending it to the controller.

@KoenZomers
Copy link
Owner

Ah I read your message as the dot being the guilty one, not the quotes. Let me try it with the quotes as well.

@KoenZomers
Copy link
Owner

Found the issue. Releasing a fix for it now.

@KoenZomers
Copy link
Owner

Fixed in version 1.1.10.1. Thanks for reporting it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants