Add support for TuYa Smart Switch with backlight ( 2, 3, 4, 6 gang configurations) #5935

Qianli-Ma · 2023-07-01T10:12:26Z

Power on behavior is still work in progress.
tuya.exposes.switch().withEndpoint('master_switch'), requires #18157 to work.

Added Terncy CL001 support

Fixed linting issues

added support for tuya G3 smart 4 gang switch with 2 scene controller

Changed model name

fix typo

…-converters

Adds support for tuya 4gang + 2 scene switch with backlight. Power on behavior is still WIP. master_switch requires Koenkk/zigbee2mqtt#18157 to work

fixed linting errors

Koenkk · 2023-07-02T06:49:05Z

src/devices/tuya.ts

+            tuya.exposes.countdown().withEndpoint('l4'),
+            tuya.exposes.countdown().withEndpoint('l5'),
+            tuya.exposes.countdown().withEndpoint('l6'),
+            tuya.exposes.switch().withEndpoint('master_switch'),


What happens if you remove tuya.exposes.switch().withEndpoint('master_switch'), here and change [13, 'state_master', tuya.valueConverter.onOff], to [13, 'state', tuya.valueConverter.onOff],, does this work?

Removing tuya.exposes.switch().withEndpoint('master_switch'), no longer exposes the master switch in the frontend.
However, publishing {"state": "ON"} and {"state": "OFF"} does the trick.

Sorry, I meant changing tuya.exposes.switch().withEndpoint('master_switch') to tuya.exposes.switch()

Changing to tuya.exposes.switch() works as properly.
But I can't seem to add an discription with tuya.exposes.switch().withDescription('All Switches'),

Moved _TZE200_wunufsil to an individual device with switch countdown timer, power on behavior, backlight control, and master switch functions.

Changed model name to reflect 2 gang control

_TZE200_0j5jma9b : fixed description fixed master switch _TZE200_wunufsil： removed extra endpoints

Added TS0601_3gang switch with backlight

Fixed duplicate _TZE200_vhy3iakz (new code supports countdown, backlight mode, and main switch) and changed some formatting

fix duplicates and format

Changed _TZE200_k6jhsr0q to support additional features

Qianli-Ma · 2023-07-02T19:28:26Z

I've updated the code to support 1,2,3,4,6 gang smart switches with backlight (have tested it with my switches).
However, I'm not sure how to change the name of the main switch into something else, such as All Switches.
Power on behavior and backlight mode works as expected.

Koenkk · 2023-07-04T14:38:54Z

src/devices/tuya.ts

+    {
+        zigbeeModel: ['TS0601_4_gang'],
+        fingerprint: [{modelID: 'TS0601', manufacturerName: '_TZE200_k6jhsr0q'}],
+        model: 'Tuya 4 Gang Smart Switch with Backlight',


For all added definitions, can you add the actual model number here? (which is listed on the product site/device itself)

I see you made some updates, please remove zigbeeModel: ['ZS-TYG3-SM-41Z'], and use it as model (e.g. model: 'ZS-TYG3-SM-41Z',

Koenkk · 2023-07-04T14:46:46Z

Note to self; after this merge Koenkk/zigbee2mqtt.io#2114

Update device names per request

Updated model names

Koenkk · 2023-07-04T15:37:37Z

src/devices/tuya.ts

+                [9, 'countdown_l3', tuya.valueConverter.countdown],
+                [10, 'countdown_l4', tuya.valueConverter.countdown],
+                [13, 'state', tuya.valueConverter.onOff],
+                [14, 'power_on_behavior', tuya.valueConverterBasic.lookup({'off': tuya.enum(0), 'on': tuya.enum(1), 'memory': tuya.enum(2)})],


One more thing;

Can you try: [14, 'power_on_behavior', tuya.valueConverter.powerOnBehavior], here and instead of e.power_on_behavior(['off', 'on', 'memory']).withAccess(ea.STATE_SET), use e.power_on_behavior() and see if that works?

I can confirm it works.

There is one issue with my implementation, the refresh for backlight_mode throws out the following error:
error 2023-07-06 18:00:32: No converter available for 'get' 'backlight_mode' ()

Get is not supported for datapoints, use tuya.exposes.backlightModeOffOn().setAccess(ea.STATE_SET)

Get is not supported for datapoints, use tuya.exposes.backlightModeOffOn().setAccess(ea.STATE_SET)

Following error is thrown when I try to use tuya.exposes.backlightModeOffOn().setAccess(ea.STATE_SET)

node:assert:399 throw err; ^ AssertionError [ERR_ASSERTION]: Does not have any features at Binary.setAccess (E:\zigbee2mqtt\zigbee2mqtt\node_modules\zigbee-herdsman-converters\src\lib\exposes.ts:62:15) at E:\zigbee2mqtt\zigbee2mqtt\data\extension\externally-loaded.js:27:43 at Script.runInContext (node:vm:141:12) at Script.runInNewContext (node:vm:146:17) at Object.runInNewContext (node:vm:300:38) at loadModuleFromText (E:\zigbee2mqtt\zigbee2mqtt\lib\util\utils.ts:151:8) at loadModuleFromFile (E:\zigbee2mqtt\zigbee2mqtt\lib\util\utils.ts:158:12) at Object.getExternalConvertersDefinitions (E:\zigbee2mqtt\zigbee2mqtt\lib\util\utils.ts:168:25) at getExternalConvertersDefinitions.next (<anonymous>) at new ExternalConverters (E:\zigbee2mqtt\zigbee2mqtt\lib\extension\externalConverters.ts:12:20)

I belive this is caused by Binary class constructor does not have features initialized, however I don't know how to use my local copy of zigbee-herdsman-converters to test out this theory.

Whoops, it should be tuya.exposes.backlightModeOffOn().withAccess(ea.STATE_SET)

I can confirm it works.

There is one issue with my implementation, the refresh for backlight_mode throws out the following error: error 2023-07-06 18:00:32: No converter available for 'get' 'backlight_mode' ()

Upon futher testing, e.power_on_behavior() and [14, 'power_on_behavior', tuya.valueConverter.powerOnBehavior] does not work

Whoops, it should be tuya.exposes.backlightModeOffOn().withAccess(ea.STATE_SET)

This works

Changed

Fixed power on behavior Fixed backlightModeOffOn get

Koenkk · 2023-07-09T11:55:57Z

thanks!

Qianli-Ma and others added 12 commits June 19, 2023 01:41

Update terncy.ts

6134521

Added Terncy CL001 support

Update terncy.ts

4403ffc

Fixed linting issues

Merge branch 'master' into master

f4b3a9d

Update tuya.ts

341bbbb

added support for tuya G3 smart 4 gang switch with 2 scene controller

Update tuya.ts

2e2cf51

Changed model name

Update tuya.ts

a65dd7a

fix typo

Update terncy.ts

b6bd0c1

Merge branch 'Koenkk:master' into master

7b74945

Merge branch 'master' of https://github.com/Qianli-Ma/zigbee-herdsman…

8357f81

…-converters

Merge branch 'Koenkk:master' into master

56bdf82

Update tuya.ts

4d051e9

Adds support for tuya 4gang + 2 scene switch with backlight. Power on behavior is still WIP. master_switch requires Koenkk/zigbee2mqtt#18157 to work

Update tuya.ts

5ea5050

fixed linting errors

Qianli-Ma changed the title ~~Add support for TuYa Smart Switch (4 gang + 2 scene) with neutral wire'~~ Add support for TuYa Smart Switch (4 gang + 2 scene) with neutral wire Jul 1, 2023

Qianli-Ma mentioned this pull request Jul 1, 2023

Added lall, switch_all, master, master_switch to endpointNames Koenkk/zigbee2mqtt#18157

Closed

Koenkk reviewed Jul 2, 2023

View reviewed changes

Qianli-Ma added 7 commits July 2, 2023 22:17

Update tuya.ts

07afe3e

Moved _TZE200_wunufsil to an individual device with switch countdown timer, power on behavior, backlight control, and master switch functions.

Update tuya.ts

58d76a7

Changed model name to reflect 2 gang control

Update tuya.ts

24940af

_TZE200_0j5jma9b : fixed description fixed master switch _TZE200_wunufsil： removed extra endpoints

Update tuya.ts

232d80e

Added TS0601_3gang switch with backlight

Update tuya.ts

e6367b4

Fixed duplicate _TZE200_vhy3iakz (new code supports countdown, backlight mode, and main switch) and changed some formatting

Update tuya.ts

f3ddb5a

fix duplicates and format

Update tuya.ts

6e669b7

Changed _TZE200_k6jhsr0q to support additional features

Qianli-Ma changed the title ~~Add support for TuYa Smart Switch (4 gang + 2 scene) with neutral wire~~ Add support for TuYa Smart Switch with backlight (1, 2, 3, 4, 6 gang configurations) Jul 2, 2023

Qianli-Ma changed the title ~~Add support for TuYa Smart Switch with backlight (1, 2, 3, 4, 6 gang configurations)~~ Add support for TuYa Smart Switch with backlight ( 2, 3, 4, 6 gang configurations) Jul 3, 2023

Qianli-Ma mentioned this pull request Jul 3, 2023

Add support for TS0601 2, 3, 4 and 6 gang switches with backlight Koenkk/zigbee2mqtt.io#2114

Merged

Koenkk reviewed Jul 4, 2023

View reviewed changes

Qianli-Ma added 2 commits July 4, 2023 23:05

Update tuya.ts

59bc2fa

Update device names per request

Update tuya.ts

0f16d0b

Updated model names

Koenkk reviewed Jul 4, 2023

View reviewed changes

Qianli-Ma and others added 3 commits July 7, 2023 18:39

Update tuya.ts

0bfcae6

Changed

Update tuya.ts

17e0ddb

Fixed power on behavior Fixed backlightModeOffOn get

Update tuya.ts

645b827

Koenkk merged commit fa5e2b9 into Koenkk:master Jul 9, 2023

Koenkk mentioned this pull request Jul 9, 2023

chore(master): release 15.38.0 #5955

Merged

github-actions bot mentioned this pull request Jul 9, 2023

chore(dev): release 1.32.1 Koenkk/zigbee2mqtt#18182

Closed

This was referenced Aug 1, 2023

chore(dev): release 1.32.2 Koenkk/zigbee2mqtt#18486

Merged

chore(dev): release 1.33.0 Koenkk/zigbee2mqtt#18488

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for TuYa Smart Switch with backlight ( 2, 3, 4, 6 gang configurations) #5935

Add support for TuYa Smart Switch with backlight ( 2, 3, 4, 6 gang configurations) #5935

Qianli-Ma commented Jul 1, 2023

Koenkk Jul 2, 2023

Qianli-Ma Jul 2, 2023

Koenkk Jul 2, 2023 •

edited

Loading

Qianli-Ma Jul 2, 2023

Qianli-Ma commented Jul 2, 2023

Koenkk Jul 4, 2023

Koenkk Jul 4, 2023

Qianli-Ma Jul 4, 2023

Koenkk commented Jul 4, 2023

Koenkk Jul 4, 2023

Qianli-Ma Jul 6, 2023

Koenkk Jul 6, 2023

Qianli-Ma Jul 7, 2023

Koenkk Jul 7, 2023

Qianli-Ma Jul 8, 2023

Qianli-Ma Jul 8, 2023

Koenkk commented Jul 9, 2023

Add support for TuYa Smart Switch with backlight ( 2, 3, 4, 6 gang configurations) #5935

Add support for TuYa Smart Switch with backlight ( 2, 3, 4, 6 gang configurations) #5935

Conversation

Qianli-Ma commented Jul 1, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Koenkk Jul 2, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Qianli-Ma commented Jul 2, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Koenkk commented Jul 4, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Koenkk commented Jul 9, 2023

Koenkk Jul 2, 2023 •

edited

Loading