HS2WD-E: remove unsupported features from exposes #8820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ghoz
commented
Feb 16, 2025
ghoz
commented
- This HS2WD-E siren has one tone only, no volume/level, no strobe level. might as well stop exposing those as it causes endless frustrations...
- Exposes a missing max_duration, that is discovered as config.
- In practice this means that no matter the duration, it will not trigger for longer than the set value to avoid runaway alarms (device defaults to 240 s).
- tested, at last a feature that is properly implemented on the siren.
…ation config This siren has one tone only, no level, no strobe level Exposes max_duration that can be set to avoid runaway alarms (device defaults to 240s) tested, at last something that is properly implemented on the siren. in practice this means that no matter the duration, it will not trigger for longer than the set value.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.