fix(ignore): remove all ubisys custom cluster/attributes #1034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For the tests, we will probably hit this again once we remove more of those attributes. |
|
Oh boy, this mrege conflict is a big pain I might close and redo this PR from scratch. The tests are the biggest pain as we basically removed all the problem childs from ubisys were we have so many tests for. |
sjorge
force-pushed
the
ubisys_clusters
branch
10 times, most recently
from
712718d to
1969391
Compare
|
Could you rebase this PR? |
sjorge
force-pushed
the
ubisys_clusters
branch
4 times, most recently
from
0bc9652 to
d980dc3
Compare
I am trying but I'm having a really hard time, the tests are broken again and I am pretty sure I rebased those correctly :/ |
|
It seems more tests got added that use ubisys attributes between me opening this one? :/ |
|
In this PR probably: f88b4d6 |
|
Seems to have been a miss-rebase with {} being added in some spots |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge after Koenkk/zigbee-herdsman-converters#7451