Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cluster.ts #1117

Merged
merged 5 commits into from
Jul 18, 2024
Merged

Update cluster.ts #1117

merged 5 commits into from
Jul 18, 2024

Conversation

turboproc
Copy link
Contributor

Some further addition to complete the cluster definitions. This PR adds the serialNumber attribute to the genBasic cluster

@turboproc
Copy link
Contributor Author

Do this again

@Koenkk
Copy link
Owner

Koenkk commented Jul 17, 2024

Could you update the tests?

@turboproc
Copy link
Contributor Author

Let me discover how the testing part works. Never done that before. Might need a little hint.

@turboproc
Copy link
Contributor Author

Updated test

@turboproc
Copy link
Contributor Author

Removed typo

@turboproc
Copy link
Contributor Author

Some more

@Koenkk Koenkk merged commit c2de0be into Koenkk:master Jul 18, 2024
1 check passed
@Koenkk
Copy link
Owner

Koenkk commented Jul 18, 2024

Thanks!

@Koenkk Koenkk mentioned this pull request Jul 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@turboproc @Koenkk