feat!: Improve permit join. #1214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Koenkk
reviewed
Oct 10, 2024
|
Could you target this against |
Nerivec
force-pushed
the
2.0.0-permit-join
branch
from
9453678 to
4abaaa8
Compare
Koenkk
pushed a commit
that referenced
this pull request
Dec 1, 2024
* feat!: Improve permit join. * Fix permitJoinTimeout never `undefined` (`0` equals disabled). * Dont allow >254sec for permit join.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ControllerAPI more closely toAdapter:(time, device?)reason(unused)getPermitJoinTimeoutreturns [0-254] range, with 0 being "not permitting joining".getPermitJoin=> usegetPermitJoinTimeoutinstead (boolean easily determined on other end of mqtt transaction -see below-)/bridge/info,/request/permit_join)TODO:
Remove unnecessary mqtt publish of/bridge/infoevery time the permit join timer ticks (the other end of mqtt transaction should be responsible for the ticks, and z2m should only publish begin -possibly end for extra sync purposes-).