Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes & general cleanup in EZSP codebase #874

Merged
merged 3 commits into from
Jan 15, 2024
Merged

Conversation

Nerivec
Copy link
Collaborator

@Nerivec Nerivec commented Jan 14, 2024

Added new Frame class to handle uart frames (cleaner & extensible).
Removed stale code.
And some formatting for good measure to make things more readable...
Should also fix a few Waitress timer issues.

@kirovilya If you don't mind checking the frame stuff, make sure I didn't miss anything with these darn buffers...

Copy link
Contributor

@kirovilya kirovilya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall normal changes

src/adapter/ezsp/driver/frame.ts Outdated Show resolved Hide resolved
@Koenkk Koenkk merged commit 39bc90a into Koenkk:master Jan 15, 2024
1 check passed
@Koenkk
Copy link
Owner

Koenkk commented Jan 15, 2024

Awesome, many thanks!

@Nerivec Nerivec deleted the ezsp-cleanup branch January 15, 2024 19:04
@mamrai1
Copy link

mamrai1 commented Jan 15, 2024

Today's changes fail to start z2m with sonof 4.4.0 and also with 7.3.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants