Use HA sensor device class atmospheric_pressure instead of pressure #18306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
This was referenced Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zigbee2MQTT currently uses the
pressuredevice class for devices that measure pressure.atmospheric_pressurewas introduced in HA 2023.1 as a more specific device class for when the pressure being measured is atmospheric pressure specifically. The pressure preset in the converters library mentions atmospheric pressure in the description, so we should be using theatmospheric_pressuredevice class instead ofpressure.I noticed this issue because HA is converting the pressure reading from my Aqara sensor to PSI which is not an appropriate unit for atmospheric pressure. This PR should fix that.