Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group with one device, two endpoints not working with latest dev branch #24792

Open
mundschenk-at opened this issue Nov 16, 2024 · 3 comments
Open
Labels
problem Something isn't working

Comments

@mundschenk-at
Copy link
Contributor

What happened?

The Hue Twilight has to light endpoints (11 and 12). Since adding support for it it in zhc, I've had a group for it to switch both lights on and off simultaneously. With dev from immediately after the release of 1.41.0, this worked fine. However, two days ago I updated to the latest dev (after the merge of my event PRs). Now that group does not work anymore. Groups containing several different devices seem to be fine.

With groups only containing endpoints from a single device, the result when trying to toggle them on looks like this:

[2024-11-16 14:01:27] debug: 	z2m:mqtt: Received MQTT message on 'zigbee2mqtt/my_group/set' with data '{"state":"ON","color":{"x":0.409,"y":0.362},"transition":0.4,"brightness":253}'
[2024-11-16 14:01:27] error: 	z2m: No converter available for 'brightness' (253)
[2024-11-16 14:01:27] error: 	z2m: No converter available for 'state' ("ON")
[2024-11-16 14:01:27] debug: 	z2m: Publishing 'set' 'color' to 'zigbee2mqtt/my_group'
[2024-11-16 14:01:27] debug: 	zh:controller:group: Command 14 lightingColorCtrl.moveToColor({"transtime":4,"colorx":26804,"colory":23724})

What did you expect to happen?

The group should work normally.

How to reproduce it (minimal and precise)

No response

Zigbee2MQTT version

1.41.0-dev

Adapter firmware version

20240710

Adapter

zStack3x0

Setup

Plain

Debug log

No response

@mundschenk-at mundschenk-at added the problem Something isn't working label Nov 16, 2024
@mundschenk-at
Copy link
Contributor Author

@Nerivec @Koenkk As soon as I add a different (single-endpoint) device to the group, it starts to work fine. Any idea where I should look?

@mundschenk-at
Copy link
Contributor Author

Trying to remove one of them fails, possibly because the command seems to target endpoint one instead of the actual group member endpoint, which might be another multi-endpoint frontend issue:

[2024-11-16 14:10:04] error: 	z2m: Failed to remove from group (ZCL command 0x00XXXXXXXXX/1 genGroups.remove({"groupid":8}, {"timeout":10000,"disableResponse":false,"disableRecovery":false,"disableDefaultResponse":true,"direction":0,"reservedBits":0,"writeUndiv":false}) failed (Timeout - 35656 - 1 - 108 - 4 - 3 after 10000ms))

@Nerivec
Copy link
Collaborator

Nerivec commented Nov 17, 2024

I've tested it with 2.0.0 branch (including frontend), with a TS0002, I can't reproduce. Removing works as well.

zh:controller:endpoint: ZCL command 0xa4c1387d3b6e41cc/2 genGroups.remove({"groupid":1}, {"timeout":10000,"disableResponse":false,"disableRecovery":false,"disableDefaultResponse":true,"direction":0,"reservedBits":0,"writeUndiv":false})

#24432 changes the logic quite a bit though, so, I guess it could have removed the problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
problem Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants