Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate -Zinstrument-coverage flag #6

Open
Kogia-sima opened this issue Nov 4, 2020 · 3 comments
Open

Investigate -Zinstrument-coverage flag #6

Kogia-sima opened this issue Nov 4, 2020 · 3 comments
Assignees

Comments

@Kogia-sima
Copy link
Owner

@Kogia-sima Kogia-sima self-assigned this Nov 4, 2020
@TriplEight
Copy link
Contributor

Hi @Kogia-sima ,
Your tool has helped me again with fixing the coverage, source-based this time. I think this could help you with your investigation.

Have to admit, it's uneasy to understand grcov's documentation, so I'm experimenting.
This is how rust-covfix fixes the coverage:

  line:   82.90% (17575 of 21201 lines)    => 81.86% (8056 of 9841 lines)
  branch: NaN% (0 of 0 branches) => NaN% (0 of 0 branches)

Even though I've passed --branch to grcov.

This is a comparison before covfix and after

@Kogia-sima
Copy link
Owner Author

@TriplEight Thanks!

@TriplEight
Copy link
Contributor

There's an explanation of why branch coverage is 0: mozilla/grcov#520

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants