fix(compilation): use private for scope of static libraries

KomodoPlatform · Sep 14, 2019 · caf4697 · caf4697
1 parent a32df71
commit caf4697
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 4 deletions.
diff --git a/examples/sfml/CMakeLists.txt b/examples/sfml/CMakeLists.txt
@@ -11,4 +11,9 @@ if (EMSCRIPTEN)
         message(STATUS "Local js compilation")
         set_target_properties(antara-sfml-example PROPERTIES LINK_FLAGS "-s FORCE_FILESYSTEM=1 -s NODERAWFS=1 -s EXIT_RUNTIME=1")
     endif ()
-endif ()
+endif ()
+
+set_target_properties(antara-sfml-example
+        PROPERTIES
+        RUNTIME_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/bin/"
+        )
diff --git a/modules/ecs/CMakeLists.txt b/modules/ecs/CMakeLists.txt
@@ -1,6 +1,6 @@
 ## shared sources between the module and his unit tests
 add_library(antara_ecs_shared_sources STATIC)
-target_sources(antara_ecs_shared_sources PUBLIC antara/gaming/ecs/base.system.cpp antara/gaming/ecs/system.manager.cpp)
+target_sources(antara_ecs_shared_sources PRIVATE antara/gaming/ecs/base.system.cpp antara/gaming/ecs/system.manager.cpp)
 target_include_directories(antara_ecs_shared_sources PUBLIC ${CMAKE_CURRENT_SOURCE_DIR})
 target_link_libraries(antara_ecs_shared_sources PUBLIC EnTT strong_type expected range-v3 antara::refl-cpp antara::default_settings antara::timer antara::event)
 add_library(antara::ecs ALIAS antara_ecs_shared_sources)

diff --git a/modules/event/CMakeLists.txt b/modules/event/CMakeLists.txt
@@ -1,6 +1,6 @@
 ## shared sources between the module and his unit tests
 add_library(antara_event_shared_sources STATIC)
-target_sources(antara_event_shared_sources PUBLIC antara/gaming/event/quit.game.cpp antara/gaming/event/fatal.error.cpp antara/gaming/event/key.pressed.cpp)
+target_sources(antara_event_shared_sources PRIVATE antara/gaming/event/quit.game.cpp antara/gaming/event/fatal.error.cpp antara/gaming/event/key.pressed.cpp)
 target_include_directories(antara_event_shared_sources PUBLIC ${CMAKE_CURRENT_SOURCE_DIR})
 target_link_libraries(antara_event_shared_sources PUBLIC antara::default_settings antara::input)
 add_library(antara::event ALIAS antara_event_shared_sources)

diff --git a/modules/timer/CMakeLists.txt b/modules/timer/CMakeLists.txt
@@ -1,6 +1,6 @@
 ## shared sources between the module and his unit tests
 add_library(antara_timer_shared_sources STATIC)
-target_sources(antara_timer_shared_sources PUBLIC antara/gaming/timer/time.step.cpp)
+target_sources(antara_timer_shared_sources PRIVATE antara/gaming/timer/time.step.cpp)
 target_include_directories(antara_timer_shared_sources PUBLIC ${CMAKE_CURRENT_SOURCE_DIR})
 target_link_libraries(antara_timer_shared_sources PUBLIC antara::default_settings)
 add_library(antara::timer ALIAS antara_timer_shared_sources)