Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(adex-cli): remove activation scheme before testing #1920

Merged
merged 1 commit into from
Jul 18, 2023
Merged

fix(adex-cli): remove activation scheme before testing #1920

merged 1 commit into from
Jul 18, 2023

Conversation

rozhkovdmitrii
Copy link

No description provided.

@rozhkovdmitrii rozhkovdmitrii self-assigned this Jul 18, 2023
@rozhkovdmitrii rozhkovdmitrii added blocked requires additional attention under review and removed blocked requires additional attention labels Jul 18, 2023
laruh
laruh reviewed Jul 18, 2023
View reviewed changes
Copy link
Member

@laruh laruh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! I have a question

mm2src/adex_cli/src/tests/mod.rs Show resolved Hide resolved
@rozhkovdmitrii rozhkovdmitrii changed the title fix(adex-cli): remove activation schem before testing fix(adex-cli): remove activation scheme before testing Jul 18, 2023
laruh
laruh approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@laruh laruh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

shamardy
shamardy approved these changes Jul 18, 2023
View reviewed changes
Copy link
Collaborator

@shamardy shamardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this test :)

@shamardy shamardy merged commit e72a0ab into dev Jul 18, 2023
@shamardy shamardy deleted the fix-adex-cli-tests branch July 18, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laruh laruh laruh approved these changes

@shamardy shamardy shamardy approved these changes

@onur-ozkan onur-ozkan Awaiting requested review from onur-ozkan

Assignees

@rozhkovdmitrii rozhkovdmitrii

Labels
under review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rozhkovdmitrii @shamardy @laruh