[r2r] update metrics related dep && refactoring #1312

borngraced · 2022-06-15T12:57:14Z

— Updating metrics related deps
— Refactoring mm_metrics

borngraced · 2022-06-20T10:26:43Z

My refactoring to look for review is work in progress in adapt.rs file @sergeyboyko0791 @shamardy

sergeyboyko0791

It would also be great if we moved mm_metrics to a separate crate like mm2_err_handle.

mm2src/common/Cargo.toml

mm2src/common/mm_metrics/adapt.rs

sergeyboyko0791

Next review iteration :)

mm2src/mm2_metrics/Cargo.toml

mm2src/mm2_metrics/src/adapt.rs

sergeyboyko0791

I could not describe all the mistakes. I'll do it on the next review iteration.

mm2src/coins/Cargo.toml

mm2src/mm2_main/Cargo.toml

mm2src/mm2_main/src/lp_ordermatch.rs

mm2src/mm2_metrics/src/adapt.rs

mm2src/mm2_metrics/src/recorder.rs

borngraced · 2022-06-26T15:11:57Z

Looking good except the tag exporter, I need a better solution as the solution I tried isn't working well

https://github.com/KomodoPlatform/atomicDEX-API/pull/1312#discussion_r906242654

…into metrics-deps-update

sergeyboyko0791

Thank you for the fixes! I hope the last my comments

mm2src/mm2_metrics/src/mm_metrics.rs

sergeyboyko0791

One important note

mm2src/mm2_metrics/src/mm_metrics.rs

sergeyboyko0791

The last review iteration

mm2src/coins/Cargo.toml

mm2src/mm2_main/src/lp_network.rs

mm2src/mm2_metrics/Cargo.toml

mm2src/mm2_metrics/src/lib.rs

mm2src/mm2_metrics/src/mm_metrics.rs

mm2src/mm2_metrics/src/recorder.rs

sergeyboyko0791

Only one change please and one suggestion

sergeyboyko0791 · 2022-08-03T10:45:32Z

mm2src/mm2_metrics/src/recorder.rs

@@ -154,20 +153,16 @@ impl MmRecorder {
    }
 }

+use std::collections::hash_map::Entry::{Occupied, Vacant};


It's better to put imports at the beginning of the file

mm2src/mm2_metrics/src/recorder.rs

…into metrics-deps-update

sergeyboyko0791

LGTM 🔥

sergeyboyko0791 · 2022-08-04T12:31:03Z

@shamardy your turn to review the PR

shamardy

Great Work! Only 2 non-blocker comments :)

mm2src/mm2_main/src/lp_network.rs

mm2src/mm2_metrics/src/mm_metrics.rs

…into metrics-deps-update

shamardy

Reapprove

sergeyboyko0791

Re-approve

artemii235 · 2022-08-09T10:45:46Z

@sergeyboyko0791 As you both approved it with @shamardy, I guess it can be merged.

sergeyboyko0791 · 2022-08-09T11:31:37Z

@artemii235 I wanted to merge it, but found an issue with the CI tests on Mac. Restarted the CI and forgot to check...
Will check now

artemii235 · 2022-08-10T09:10:06Z

@sergeyboyko0791 If you see errors only on one platform and there are only unstable tests failures, you can merge the PR right away without restarting the CI.

update metrics related dep

fe04dfd

borngraced requested review from sergeyboyko0791 and shamardy June 15, 2022 12:57

wasm don't mess up!

6dde2f0

borngraced changed the title ~~update metrics related dep~~ [WIP] update metrics related dep Jun 16, 2022

borngraced marked this pull request as draft June 17, 2022 21:25

borngraced added 4 commits June 17, 2022 22:25

wip

39fac2a

wip

dad1905

impl collect_json done

81f0838

added collect_json test

0143dac

borngraced marked this pull request as ready for review June 20, 2022 10:25

borngraced changed the title ~~[WIP] update metrics related dep~~ [WIP] update metrics related dep && refactoring Jun 20, 2022

sergeyboyko0791 reviewed Jun 20, 2022

View reviewed changes

borngraced added 3 commits June 21, 2022 09:04

created new mm2_metrics crate and other wip impls

4aeeaa9

update wasm

526cee4

rust fmt check

75a545a

sergeyboyko0791 suggested changes Jun 21, 2022

View reviewed changes

borngraced added 3 commits June 22, 2022 07:13

wip

06df12e

MetricsArc && MetricsWeak

2fda9cd

wip

942e5b9

sergeyboyko0791 suggested changes Jun 24, 2022

View reviewed changes

wip

3c274aa

borngraced added 3 commits June 26, 2022 16:16

removed unused dep

ae7829f

Merge branch 'dev' of https://github.com/KomodoPlatform/atomicDEX-API …

a0f5908

…into metrics-deps-update

refactoring

a86bef9

borngraced changed the title ~~[WIP] update metrics related dep && refactoring~~ [r2r] update metrics related dep && refactoring Jun 29, 2022

removed unused deps

23af3b8

borngraced linked an issue Jun 29, 2022 that may be closed by this pull request

Update metrics related deps. #1299

Closed

sergeyboyko0791 suggested changes Jul 29, 2022

View reviewed changes

mm2src/mm2_metrics/src/mm_metrics.rs Outdated Show resolved Hide resolved

mm2src/mm2_metrics/src/mm_metrics.rs Outdated Show resolved Hide resolved

mm2src/mm2_metrics/src/mm_metrics.rs Outdated Show resolved Hide resolved

Changes to error handling and unit tests

3ec0d88

sergeyboyko0791 suggested changes Jul 29, 2022

View reviewed changes

mm2src/mm2_metrics/src/mm_metrics.rs Outdated Show resolved Hide resolved

Fixed test_collect_json test deltas

7cf9cc0

sergeyboyko0791 suggested changes Jul 29, 2022

View reviewed changes

borngraced added 2 commits August 1, 2022 10:39

PR review fixes - 3

63b5713

edited lp_commands_legacy

f81d62e

borngraced changed the title ~~[wip] update metrics related dep && refactoring~~ [r2r] update metrics related dep && refactoring Aug 1, 2022

PR review fix - last

4e813bb

sergeyboyko0791 suggested changes Aug 3, 2022

View reviewed changes

borngraced added 3 commits August 4, 2022 12:59

Minor changes - r2r

c9544ff

fix cargo clippy

8a2e021

Merge branch 'dev' of https://github.com/KomodoPlatform/atomicDEX-API …

decaae2

…into metrics-deps-update

sergeyboyko0791 previously approved these changes Aug 4, 2022

View reviewed changes

shamardy previously approved these changes Aug 4, 2022

View reviewed changes

mm2src/mm2_main/src/lp_network.rs Outdated Show resolved Hide resolved

mm2src/mm2_metrics/src/mm_metrics.rs Outdated Show resolved Hide resolved

final pr review changes

914cfd0

borngraced dismissed stale reviews from shamardy and sergeyboyko0791 via 914cfd0 August 5, 2022 09:15

borngraced added 2 commits August 5, 2022 10:20

Merge branch 'dev' of https://github.com/KomodoPlatform/atomicDEX-API …

9d16b20

…into metrics-deps-update

fixed build error

5797bc4

shamardy approved these changes Aug 5, 2022

View reviewed changes

sergeyboyko0791 approved these changes Aug 5, 2022

View reviewed changes

sergeyboyko0791 merged commit 0351464 into dev Aug 10, 2022

sergeyboyko0791 deleted the metrics-deps-update branch August 10, 2022 10:25

shamardy mentioned this pull request Sep 1, 2022

[r2r] Update rust-lightning to latest version, 0_confs channels, complete btc spv, multiple fixes #1452

Merged

borngraced mentioned this pull request Feb 17, 2023

[release] 1.0.0-beta #1576

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[r2r] update metrics related dep && refactoring #1312

[r2r] update metrics related dep && refactoring #1312

borngraced commented Jun 15, 2022 •

edited

Loading

borngraced commented Jun 20, 2022 •

edited

Loading

sergeyboyko0791 left a comment

sergeyboyko0791 left a comment

sergeyboyko0791 left a comment

borngraced commented Jun 26, 2022

sergeyboyko0791 left a comment

sergeyboyko0791 left a comment

sergeyboyko0791 left a comment

sergeyboyko0791 left a comment

sergeyboyko0791 Aug 3, 2022

borngraced Aug 4, 2022

sergeyboyko0791 left a comment

sergeyboyko0791 commented Aug 4, 2022

shamardy left a comment

shamardy left a comment

sergeyboyko0791 left a comment

artemii235 commented Aug 9, 2022

sergeyboyko0791 commented Aug 9, 2022

artemii235 commented Aug 10, 2022

[r2r] update metrics related dep && refactoring #1312

[r2r] update metrics related dep && refactoring #1312

Conversation

borngraced commented Jun 15, 2022 • edited Loading

borngraced commented Jun 20, 2022 • edited Loading

sergeyboyko0791 left a comment

Choose a reason for hiding this comment

sergeyboyko0791 left a comment

Choose a reason for hiding this comment

sergeyboyko0791 left a comment

Choose a reason for hiding this comment

borngraced commented Jun 26, 2022

sergeyboyko0791 left a comment

Choose a reason for hiding this comment

sergeyboyko0791 left a comment

Choose a reason for hiding this comment

sergeyboyko0791 left a comment

Choose a reason for hiding this comment

sergeyboyko0791 left a comment

Choose a reason for hiding this comment

sergeyboyko0791 Aug 3, 2022

Choose a reason for hiding this comment

borngraced Aug 4, 2022

Choose a reason for hiding this comment

sergeyboyko0791 left a comment

Choose a reason for hiding this comment

sergeyboyko0791 commented Aug 4, 2022

shamardy left a comment

Choose a reason for hiding this comment

shamardy left a comment

Choose a reason for hiding this comment

sergeyboyko0791 left a comment

Choose a reason for hiding this comment

artemii235 commented Aug 9, 2022

sergeyboyko0791 commented Aug 9, 2022

artemii235 commented Aug 10, 2022

borngraced commented Jun 15, 2022 •

edited

Loading

borngraced commented Jun 20, 2022 •

edited

Loading